You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "infdahai (via GitHub)" <gi...@apache.org> on 2023/05/18 16:17:31 UTC

[GitHub] [incubator-kvrocks] infdahai opened a new issue, #1447: use clang-16 && gcc-13 to build

infdahai opened a new issue, #1447:
URL: https://github.com/apache/incubator-kvrocks/issues/1447

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   This issue have a request to use `clang-16` and `gcc-13` to build docker images or `cmakelists.txt` in local developing envrioments and use `clang-tidy-16` and `clang-format-16` to correct code formattings.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1447: use clang-16 && gcc-13 to build

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1447:
URL: https://github.com/apache/incubator-kvrocks/issues/1447#issuecomment-1596108175

   > for clang-16, we can refer to
   > 
   > https://github.com/MikePopoloski/slang/blob/385e8e3a666551416fe76fcd9f0d6f0ba845b9bc/.github/workflows/build.yml#L40-L46
   > 
   > or execute the shell script.
   > 
   > ```yaml
   >           wget https://apt.llvm.org/llvm.sh
   >           chmod +x llvm.sh
   >           sudo ./llvm.sh 16
   >           sudo apt-get install -y clang-tidy-16
   > ```
   > 
   > But I havn't found a vaild example for gcc-13. What do you think @PragmaTwice or just pend for this?
   
   We can add a PPA for ubuntu, refer to https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/ppa .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] infdahai commented on issue #1447: use clang-16 && gcc-13 to build

Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1447:
URL: https://github.com/apache/incubator-kvrocks/issues/1447#issuecomment-1595654941

   for clang-16, we can refer to
   
   https://github.com/MikePopoloski/slang/blob/385e8e3a666551416fe76fcd9f0d6f0ba845b9bc/.github/workflows/build.yml#L40-L46 
   
   or 
   
   ```yaml
             wget https://apt.llvm.org/llvm.sh
             chmod +x llvm.sh
             sudo ./llvm.sh 16
             sudo apt-get install -y clang-tidy-16
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] torwig commented on issue #1447: use clang-16 && gcc-13 to build

Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on issue #1447:
URL: https://github.com/apache/incubator-kvrocks/issues/1447#issuecomment-1553316823

   @infdahai If Ubuntu 20.04 has clang-16 in its repository?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1447: use clang-16 && gcc-13 to build

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1447:
URL: https://github.com/apache/incubator-kvrocks/issues/1447#issuecomment-1594997993

   I have been using GCC 13 to build kvrocks for a long time and haven't encountered any issues so far. 
   
   Getting GCC 13 or Clang 16 in CI may require manual download and installation, but I don't object to adding new compiler builds in CI (currently, the default versions of GCC and Clang in both ubuntu20 and ubuntu22 are used in CI).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] infdahai commented on issue #1447: use clang-16 && gcc-13 to build

Posted by "infdahai (via GitHub)" <gi...@apache.org>.
infdahai commented on issue #1447:
URL: https://github.com/apache/incubator-kvrocks/issues/1447#issuecomment-1553384780

   No. `clang-10` is the default version in [`ubuntu 20.04`](https://packages.ubuntu.com/focal/clang])


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org