You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/02/08 11:13:25 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #4049: [ZEPPELIN-5242] Change **/interpreter/** to interpreter/**

Reamer opened a new pull request #4049:
URL: https://github.com/apache/zeppelin/pull/4049


   ### What is this PR for?
   This PR corrects the rat exclusion `**/interpreter/**` which is too wide. I think we should only exclude the interpreter folder from the root path.
   
   ### What type of PR is it?
    - Bug Fix
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5242
   
   ### How should this be tested?
   * CI
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4049: [ZEPPELIN-5242] Change **/interpreter/** to interpreter/**

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4049:
URL: https://github.com/apache/zeppelin/pull/4049#issuecomment-776083396


   I will merge this PR into master and branch-0.9 on Wednesday (10/02/2021) if no further comments are received.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4049: [ZEPPELIN-5242] Change **/interpreter/** to interpreter/**

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4049:
URL: https://github.com/apache/zeppelin/pull/4049


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4049: [ZEPPELIN-5242] Change **/interpreter/** to interpreter/**

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4049:
URL: https://github.com/apache/zeppelin/pull/4049#issuecomment-775891197


   @zjffdu Any thoughts on this amended exclusion rule?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4049: [ZEPPELIN-5242] Change **/interpreter/** to interpreter/**

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4049:
URL: https://github.com/apache/zeppelin/pull/4049#issuecomment-775949908


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org