You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/06/16 22:05:08 UTC
[GitHub] [groovy] sandipchitale opened a new pull request, #1728: Support launching of ObjectExplore when property rows are double clic…
sandipchitale opened a new pull request, #1728:
URL: https://github.com/apache/groovy/pull/1728
Support launching of ObjectExplore when property rows are double-clicked. Also, support the Array tab aside from Collection and Map Tabs.
Launch ObjectExplorer from Groovy Console or groovysh with **:inspect** command. Once ObjectExplorer is launched double-clicking on a property row will launch another instance of ObjectExplorer focused on that property's value. This works on Array, Collection, Map, and Properties table rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] sandipchitale commented on pull request #1728: Support launching of ObjectExplore when property rows are double clic…
Posted by GitBox <gi...@apache.org>.
sandipchitale commented on PR #1728:
URL: https://github.com/apache/groovy/pull/1728#issuecomment-1159546890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1728: Support launching of ObjectExplore when property rows are double clic…
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on PR #1728:
URL: https://github.com/apache/groovy/pull/1728#issuecomment-1160490584
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1728: Support launching of ObjectExplore when property rows are double clic…
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on PR #1728:
URL: https://github.com/apache/groovy/pull/1728#issuecomment-1160047219
This looks like a great contribution! I created this issue to track it: https://issues.apache.org/jira/browse/GROOVY-10661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1728: Support launching of ObjectExplore when property rows are double clic…
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #1728:
URL: https://github.com/apache/groovy/pull/1728#discussion_r899632620
##########
src/main/java/groovy/inspect/Inspector.java:
##########
@@ -290,6 +319,17 @@ protected String[] withoutNulls(String[] toNormalize) {
return toNormalize;
}
+ protected Object[] withoutNullsWithRawValue(Object[] toNormalize) {
+ for (int i = 0; i < toNormalize.length; i++) {
+ if (toNormalize[i] instanceof String) {
+ } else if (toNormalize[i] instanceof Object) {
Review Comment:
*[BadInstanceof](https://errorprone.info/bugpattern/BadInstanceof):* `toNormalize[i]` is an instance of Object which is a subtype of Object, so this is equivalent to a null check.
```suggestion
} else if (toNormalize[i] != null) {
```
Reply with *"**@sonatype-lift help**"* for more info.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=280143891&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=280143891&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=280143891&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=280143891&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=280143891&lift_comment_rating=5) ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] sandipchitale commented on a diff in pull request #1728: Support launching of ObjectExplore when property rows are double clic…
Posted by GitBox <gi...@apache.org>.
sandipchitale commented on code in PR #1728:
URL: https://github.com/apache/groovy/pull/1728#discussion_r899712573
##########
src/main/java/groovy/inspect/Inspector.java:
##########
@@ -290,6 +319,17 @@ protected String[] withoutNulls(String[] toNormalize) {
return toNormalize;
}
+ protected Object[] withoutNullsWithRawValue(Object[] toNormalize) {
+ for (int i = 0; i < toNormalize.length; i++) {
+ if (toNormalize[i] instanceof String) {
+ } else if (toNormalize[i] instanceof Object) {
Review Comment:
Implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert closed pull request #1728: Support launching of ObjectExplore when property rows are double clic…
Posted by GitBox <gi...@apache.org>.
paulk-asert closed pull request #1728: Support launching of ObjectExplore when property rows are double clic…
URL: https://github.com/apache/groovy/pull/1728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org