[jira] [Resolved] (HBASE-24591) get_table_rsgroup ignored the existence of rsgroup config for namespace

["Duo Zhang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-24591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-24591.
-------------------------------
    Hadoop Flags: Reviewed
      Resolution: Fixed

Merged to master.

Thanks [~Ddupg] for contributing.

> get_table_rsgroup ignored the existence of rsgroup config for namespace
> -----------------------------------------------------------------------
>
>                 Key: HBASE-24591
>                 URL: https://issues.apache.org/jira/browse/HBASE-24591
>             Project: HBase
>          Issue Type: Bug
>          Components: rsgroup
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: Sun Xin
>            Assignee: Sun Xin
>            Priority: Major
>             Fix For: 3.0.0-alpha-1
>
>
> {code:java}
> public GetRSGroupInfoOfTableResponse getRSGroupInfoOfTable(RpcController controller,
>   GetRSGroupInfoOfTableRequest request) throws ServiceException {
>   TableName tableName = ProtobufUtil.toTableName(request.getTableName());
>   ...
>   try {
>     ...
>     GetRSGroupInfoOfTableResponse resp;
>     TableDescriptor td = master.getTableDescriptors().get(tableName);
>     if (td == null) {
>       resp = GetRSGroupInfoOfTableResponse.getDefaultInstance();
>     } else {
>       RSGroupInfo rsGroupInfo = null;
>       if (td.getRegionServerGroup().isPresent()) {
>         rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(td.getRegionServerGroup().get());
>       }
>       if (rsGroupInfo == null) {
>         rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(RSGroupInfo.DEFAULT_GROUP);
>       }
>       resp = GetRSGroupInfoOfTableResponse.newBuilder()
>         .setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(rsGroupInfo)).build();
>     }
>     ...
>     return resp;
>   } catch (IOException e) {
>     throw new ServiceException(e);
>   }
> }
> {code}
> In method MasterRpcServices#getRSGroupInfoOfTable, ignored namespace hbase.rsgroup.name config. 
>  
> It should be replaced by RSGroupUtil#getRSGroupInfo. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)