You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/10/20 11:47:47 UTC
Review Request 39472: Added the helper container InheritanceTree
where nodes inherit values from their ancestors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39472/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Till Toenshoff.
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
Introduces the `InheritanceTree` class which allows to create a tree where nodes can be tag with some property. This property is then inherited by children nodes.
It relates to [r/37996/](https://reviews.apache.org/r/37996/). It moves the `InheritanceTree` to the place it will be used in the next review so as to not pollute stout. Unit tests cannot be directly performed because now the structure has not public visibility so the tests will be execute as integration tests in future reviews when the structure is used.
Diffs
-----
3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271
Diff: https://reviews.apache.org/r/39472/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 39472: Added the helper container InheritanceTree
where nodes inherit values from their ancestors.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39472/#review103266
-----------------------------------------------------------
Ship it!
This code has already been reviewed in this RR: https://reviews.apache.org/r/37996/
The conclusion was that it needs to be moved out of stout to where it is going to be used.
So we are going with that.
- Bernd Mathiske
On Oct. 20, 2015, 7:24 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39472/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 7:24 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
>
>
> Bugs: MESOS-3231
> https://issues.apache.org/jira/browse/MESOS-3231
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces the `InheritanceTree` class which allows to create a tree where nodes can be tag with some property. This property is then inherited by children nodes.
>
> It relates to [r/37996/](https://reviews.apache.org/r/37996/). It moves the `InheritanceTree` to the place it will be used in the next review so as to not pollute stout. Unit tests cannot be directly performed because now the structure has not public visibility so the tests will be execute as integration tests in future reviews when the structure is used.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271
>
> Diff: https://reviews.apache.org/r/39472/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 39472: Added the helper container InheritanceTree
where nodes inherit values from their ancestors.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39472/
-----------------------------------------------------------
(Updated Oct. 20, 2015, 4:24 p.m.)
Review request for mesos, Bernd Mathiske and Till Toenshoff.
Changes
-------
Added documentation.
Bugs: MESOS-3231
https://issues.apache.org/jira/browse/MESOS-3231
Repository: mesos
Description
-------
Introduces the `InheritanceTree` class which allows to create a tree where nodes can be tag with some property. This property is then inherited by children nodes.
It relates to [r/37996/](https://reviews.apache.org/r/37996/). It moves the `InheritanceTree` to the place it will be used in the next review so as to not pollute stout. Unit tests cannot be directly performed because now the structure has not public visibility so the tests will be execute as integration tests in future reviews when the structure is used.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 954d31424bc8f8ecfa78b80513c480f2514ec271
Diff: https://reviews.apache.org/r/39472/diff/
Testing
-------
make check
Thanks,
Alexander Rojas