You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/02/06 23:28:24 UTC
[GitHub] [superset] justinpark opened a new pull request, #23007: fix(sqllab): regression of clearQueryResults
justinpark opened a new pull request, #23007:
URL: https://github.com/apache/superset/pull/23007
### SUMMARY
This PR fixes a bug introduced by (https://github.com/apache/superset/pull/21186) that caused increasing local storage size dramatically (which makes the space limitation warning frequently). This is because the migration logic flip to `query.cached` from `!nextProps.query.cached` so `clearQueryResults()` never triggered.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- After:
<img width="701" alt="Superset-3" src="https://user-images.githubusercontent.com/1392866/217110237-fcb9fb1a-403b-410d-90cd-2f4a0bfdb18b.png">
<img width="466" alt="Superset-2" src="https://user-images.githubusercontent.com/1392866/217110245-2a1bd0e7-062f-4625-b42f-97b75232a4b2.png">
- Before:
<img width="703" alt="Superset-4" src="https://user-images.githubusercontent.com/1392866/217110272-d121c50c-eeab-466b-8362-20c55ad34df3.png">
<img width="489" alt="Superset" src="https://user-images.githubusercontent.com/1392866/217110301-f450ca78-27d7-42d8-a772-ff071a52e958.png">
### TESTING INSTRUCTIONS
Go to SqlLab
Run a query and check the localStorage of sqlLab > queries > results > data
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark closed pull request #23007: fix(sqllab): regression of clearQueryResults
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark closed pull request #23007: fix(sqllab): regression of clearQueryResults
URL: https://github.com/apache/superset/pull/23007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #23007: fix(sqllab): regression of clearQueryResults
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #23007:
URL: https://github.com/apache/superset/pull/23007#issuecomment-1419962491
Found a bunch of regression. I will post new PR to clean up all issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org