[jira] [Commented] (HDFS-6582) Missing null check in RpcProgramNfs3#read(XDR, SecurityHandler)

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-6582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087515#comment-14087515 ] 

Hadoop QA commented on HDFS-6582:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12660100/HDFS-6582.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs:

                  org.apache.hadoop.hdfs.nfs.TestMountd
                  org.apache.hadoop.hdfs.nfs.nfs3.TestExportsTable
                  org.apache.hadoop.hdfs.nfs.nfs3.TestClientAccessPrivilege
                  org.apache.hadoop.hdfs.nfs.nfs3.TestReaddir
                  org.apache.hadoop.hdfs.nfs.nfs3.TestWrites
                  org.apache.hadoop.hdfs.nfs.nfs3.TestRpcProgramNfs3

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7571//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7571//console

This message is automatically generated.

> Missing null check in RpcProgramNfs3#read(XDR, SecurityHandler)
> ---------------------------------------------------------------
>
>                 Key: HDFS-6582
>                 URL: https://issues.apache.org/jira/browse/HDFS-6582
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>            Reporter: Ted Yu
>            Assignee: Abhiraj Butala
>            Priority: Minor
>         Attachments: HDFS-6582.patch
>
>
> Around line 691:
> {code}
>         FSDataInputStream fis = clientCache.getDfsInputStream(userName,
>             Nfs3Utils.getFileIdPath(handle));
>         try {
>           readCount = fis.read(offset, readbuffer, 0, count);
> {code}
> fis may be null, leading to NullPointerException



--
This message was sent by Atlassian JIRA
(v6.2#6252)