You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/05 08:13:43 UTC

[GitHub] [flink] zentol opened a new pull request, #20162: [FLINK-26600][tests] Wait with savepoint until job is running

zentol opened a new pull request, #20162:
URL: https://github.com/apache/flink/pull/20162

   It only makes sense to trigger savepoints when the job is actually RUNNING. Triggering a savepoint while the job is in the CREATED state is tolerated in the default scheduler (even though the checkpoint will immediately fail), but the adaptive scheduler rejects it eagerly.
   
   Ideally we'd align the behavior in a follow-up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20162: [FLINK-26600][tests] Wait with savepoint until job is running

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20162:
URL: https://github.com/apache/flink/pull/20162#issuecomment-1175871127

   > WDYM? It waits indefinitely until the condition is fulfilled.
   
   I was more worried about it waiting/validating every 50 milliseconds with impact on resource usage, but if it's fine, let's get this merged :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20162: [FLINK-26600][tests] Wait with savepoint until job is running

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20162:
URL: https://github.com/apache/flink/pull/20162#issuecomment-1174761094

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "788ec088b39a8182cf6a2f757c785307ce7505ff",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "788ec088b39a8182cf6a2f757c785307ce7505ff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 788ec088b39a8182cf6a2f757c785307ce7505ff UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #20162: [FLINK-26600][tests] Wait with savepoint until job is running

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20162:
URL: https://github.com/apache/flink/pull/20162#issuecomment-1175861706

   WDYM? It waits indefinitely until the condition is fulfilled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #20162: [FLINK-26600][tests] Wait with savepoint until job is running

Posted by GitBox <gi...@apache.org>.
zentol merged PR #20162:
URL: https://github.com/apache/flink/pull/20162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #20162: [FLINK-26600][tests] Wait with savepoint until job is running

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20162:
URL: https://github.com/apache/flink/pull/20162#issuecomment-1176011398

   I see; I don't think we need to worry about that; 50ms is a surprisingly long time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org