You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nikita Slyusarev <ns...@yandex-team.com> on 2018/07/11 22:19:02 UTC
[PATCH] fix repos-to-wc copy dst parents creation
[[[
Correctly handle existing parent directories when performing repos-to-wc copy.
* subversion/libsvn_client/copy.c
(repos_to_wc_copy): If add_parents flag is set and destination parent
directory exists, but is unversioned, put it under version control. Wc-to-wc
copy behaves this way, and so should repos-to-wc copy do.
]]]
--
Nikita Slyusarev
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Julian Foad <ju...@apache.org>.
> Nikita Slyusarev wrote on 04 Aug 2018:
> > For everyone's sanity I'd better not only bump the thread, but also
> > resend the patch and the log message I had prepared back then.
Daniel Shahaf wrote:
> Filed SVN-4768. If anyone could review the patch, that'd be great;
Thank you Nikita for continuing to push this. We are grateful for your contribution, and only limited by having very few active contributors. I have your email marked for attention in my mail box. I will make sure I get to it soon-ish if nobody else does.
--
- Julian
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Daniel Shahaf <da...@apache.org>.
Nikita Slyusarev wrote on Sat, 04 Aug 2018 17:47 +0300:
> For everyone's sanity I'd better not only bump the thread, but also
> resend the patch and the log message I had prepared back then.
>
Filed SVN-4768. If anyone could review the patch, that'd be great;
it's a one-liner fix with a test...
> [[[
> Correctly handle existing parent directories when performing repos-to-wc copy.
>
> * subversion/libsvn_client/copy.c
> (repos_to_wc_copy): If add_parents flag is set and destination parent
> directory exists, but is unversioned, put it under version control. Wc-to-wc
> copy behaves this way, and so should repos-to-wc copy do.
>
> * subversion/tests/cmdline/copy_tests.py
> (copy_make_parents_repo_wc,
> copy_make_parents_wc_wc): Check behaviour with dst directory pre-creation
> for both repo-to-wc and wc-to-wc test cases.
> ]]]
>
> Email had 1 attachment:
> + subversion-libsvn_client-copy-with_tests.patch
> 6k (text/x-diff)
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Branko Čibej <br...@apache.org>.
On 14.10.2018 21:39, Nikita Slyusarev wrote:
> 14.10.2018, 17:17, "Branko Čibej" <br...@apache.org>:
> >
> > Hey. Thanks for the nudge.
> >
> > I have just one comment: The two new test scenarios you should be split
> > into their own test cases. Not only is it bad practice to make a test
> > case test more than one scenario, it also defeats parallel test execution.
> >
> Fixed version (the patch is also attached):
> [[[
> Correctly handle existing parent directories when performing repos-to-wc copy.
> * subversion/libsvn_client/copy.c
> (repos_to_wc_copy): If add_parents flag is set and destination parent
> directory exists, but is unversioned, put it under version control. Wc-to-wc
> copy behaves this way, and so should repos-to-wc copy do.
> * subversion/tests/cmdline/copy_tests.py
> (copy_make_parents_repo_wc_existing_unversioned_dst,
> copy_make_parents_wc_wc_existing_unversioned_dst): Check behaviour with dst
> directory pre-creation for both repo-to-wc and wc-to-wc test cases.
> ]]]
r1843888; thanks!
-- Brane
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Nikita Slyusarev <ns...@yandex-team.com>.
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Branko Čibej <br...@apache.org>.
On 14.10.2018 15:48, Nikita Slyusarev wrote:
>
> 04.08.2018, 17:47, "Nikita Slyusarev" <ns...@yandex-team.com>:
>>
>> For everyone's sanity I'd better not only bump the thread, but also
>> resend the patch and the log message I had prepared back then.
>>
>> 14.07.2018, 19:04, "Nikita Slyusarev" <nslus@yandex-team.com
>> <ma...@yandex-team.com>>:
>>
>>
>>
>> [[[
>> Correctly handle existing parent directories when performing
>> repos-to-wc copy.
>>
>> * subversion/libsvn_client/copy.c
>> (repos_to_wc_copy): If add_parents flag is set and destination
>> parent
>> directory exists, but is unversioned, put it under version
>> control. Wc-to-wc
>> copy behaves this way, and so should repos-to-wc copy do.
>>
>> * subversion/tests/cmdline/copy_tests.py
>> (copy_make_parents_repo_wc,
>> copy_make_parents_wc_wc): Check behaviour with dst directory
>> pre-creation
>> for both repo-to-wc and wc-to-wc test cases.
>> ]]]
>>
>>
>
>
> Hello, guys, any hope to get this reviewed?
Hey. Thanks for the nudge.
I have just one comment: The two new test scenarios you should be split
into their own test cases. Not only is it bad practice to make a test
case test more than one scenario, it also defeats parallel test execution.
-- Brane
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Nikita Slyusarev <ns...@yandex-team.com>.
For everyone's sanity I'd better not only bump the thread, but also resend the patch and the log message I had prepared back then.
14.07.2018, 19:04, "Nikita Slyusarev" <ns...@yandex-team.com>:
> 14.07.2018, 17:18, "Daniel Shahaf" <da...@apache.org>:
>> It would help to add a regression test to subversion/tests/cmdline/ or
>> subversion/tests/libsvn_client/.
>
> Thanks for your advice. I've added cmdline tests to the patch and fixed the log
> message accordingly.
[[[
Correctly handle existing parent directories when performing repos-to-wc copy.
* subversion/libsvn_client/copy.c
(repos_to_wc_copy): If add_parents flag is set and destination parent
directory exists, but is unversioned, put it under version control. Wc-to-wc
copy behaves this way, and so should repos-to-wc copy do.
* subversion/tests/cmdline/copy_tests.py
(copy_make_parents_repo_wc,
copy_make_parents_wc_wc): Check behaviour with dst directory pre-creation
for both repo-to-wc and wc-to-wc test cases.
]]]
--
Nikita Slyusarev
Yandex
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Nikita Slyusarev <ns...@yandex-team.com>.
14.07.2018, 17:18, "Daniel Shahaf" <da...@apache.org>:
> It would help to add a regression test to subversion/tests/cmdline/ or
> subversion/tests/libsvn_client/.
Thanks for your advice. I've added cmdline tests to the patch and fixed the log
message accordingly.
[[[
Correctly handle existing parent directories when performing repos-to-wc copy.
* subversion/libsvn_client/copy.c
(repos_to_wc_copy): If add_parents flag is set and destination parent
directory exists, but is unversioned, put it under version control. Wc-to-wc
copy behaves this way, and so should repos-to-wc copy do.
* subversion/tests/cmdline/copy_tests.py
(copy_make_parents_repo_wc,
copy_make_parents_wc_wc): Check behaviour with dst directory pre-creation
for both repo-to-wc and wc-to-wc test cases.
]]]
--
Nikita Slyusarev
Yandex
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Nikita Slyusarev <ns...@yandex-team.com>.
Bump?
20.07.2018, 11:04, "Nikita Slyusarev" <ns...@yandex-team.com>:
> 14.07.2018, 20:05, "Daniel Shahaf" <da...@apache.org>:
>> The submission includes a log message and an explanation of the problem. In
>> that regard it is complete and ready for review. That will hopefully happen on
>> Monday. Should you not get a response, do prod us again.
>
> Hello. Any news with the review process?
> Not to be bothersome or to hurry, but to ensure that the submission is not lost.
--
Nikita Slyusarev
Yandex
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Nikita Slyusarev <ns...@yandex-team.com>.
14.07.2018, 20:05, "Daniel Shahaf" <da...@apache.org>:
> The submission includes a log message and an explanation of the problem. In
> that regard it is complete and ready for review. That will hopefully happen on
> Monday. Should you not get a response, do prod us again.
Hello. Any news with the review process?
Not to be bothersome or to hurry, but to ensure that the submission is not lost.
--
Nikita Slyusarev
Yandex
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Daniel Shahaf <da...@apache.org>.
Nikita Slyusarev wrote on Sat, Jul 14, 2018 at 13:19:54 +0300:
> Hello. This patch fixes svn copy behaviour. Let's discuss.
> What are my next steps here? Can I help somehow with patch acceptance?
The submission includes a log message and an explanation of the problem. In
that regard it is complete and ready for review. That will hopefully happen on
Monday. Should you not get a response, do prod us again.
It would help to add a regression test to subversion/tests/cmdline/ or
subversion/tests/libsvn_client/.
Cheers,
Daniel
> 12.07.2018, 01:19, "Nikita Slyusarev" <ns...@yandex-team.com>:
> > [[[
> > Correctly handle existing parent directories when performing repos-to-wc copy.
> >
> > * subversion/libsvn_client/copy.c
> > (repos_to_wc_copy): If add_parents flag is set and destination parent
> > directory exists, but is unversioned, put it under version control. Wc-to-wc
> > copy behaves this way, and so should repos-to-wc copy do.
> > ]]]
Re: [PATCH] fix repos-to-wc copy dst parents creation
Posted by Nikita Slyusarev <ns...@yandex-team.com>.
Hello. This patch fixes svn copy behaviour. Let's discuss.
What are my next steps here? Can I help somehow with patch acceptance?
12.07.2018, 01:19, "Nikita Slyusarev" <ns...@yandex-team.com>:
> [[[
> Correctly handle existing parent directories when performing repos-to-wc copy.
>
> * subversion/libsvn_client/copy.c
> (repos_to_wc_copy): If add_parents flag is set and destination parent
> directory exists, but is unversioned, put it under version control. Wc-to-wc
> copy behaves this way, and so should repos-to-wc copy do.
> ]]]
--
Nikita Slyusarev
Yandex