You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Matthias Pohl <ma...@aiven.io.INVALID> on 2023/02/01 11:10:28 UTC
Re: [DISCUSS] Delete useless branches from Flink repository
I'm documenting the branches that shouldn't be deleted in the release
management docs [1]. While going through the remote branches I noticed the
remote branch blink [2] which was created by Kurt in 2019. It feels like
that one could be deleted as well.
Are there any objections in deleting the blink remote branch? @Leonard was
there any reason you skipped that one?
[1]
https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management
[2] https://github.com/apache/flink/tree/blink
On Tue, Nov 1, 2022 at 11:26 AM Leonard Xu <xb...@gmail.com> wrote:
> Thanks Yun Tang for joining the discussion.
>
> I’ve deleted these branches with same name tag except release-1.14.6-rc2
> which has no same name tag.
>
> release-1.12.3-rc1
> release-1.13.2-rc2
> release-1.14.3-rc1
> release-1.15.0-rc1
> release-1.14.6-rc2
>
> Best,
> Leonard
>
>
>
> >
> > Hi Leonard,
> >
> > Thanks for driving this topic, I think the release candidate branch
> after flink-1.10 could be deleted.
> >
> > I believe those branches are created by mistake as the release manager
> should use tags instead of branch to hold the release candidate.
> > Those branches are:
> > release-1.12.3-rc1
> > release-1.13.2-rc2
> > release-1.14.3-rc1
> > release-1.14.6-rc2
> > release-1.15.0-rc1
> >
> >
> > Best
> > Yun Tang
> > ________________________________
> > From: Leonard Xu <xb...@gmail.com>
> > Sent: Monday, October 31, 2022 20:07
> > To: dev@flink.apache.org <de...@flink.apache.org>
> > Subject: Re: [DISCUSS] Delete useless branches from Flink repository
> >
> >
> >> Actually I double checked it and the default branch on jenkins is
> `master`.
> >
> > Great, I’ve deleted benchmark-request branch. Now, our repo looks better.
> >
> > Best,
> > Leonard
>
>
Re: [DISCUSS] Delete useless branches from Flink repository
Posted by Matthias Pohl <ma...@aiven.io.INVALID>.
Thanks for clarification. I'm gonna leave the branch and document it
accordingly in [1].
[1]
https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management
On Wed, Feb 1, 2023 at 1:29 PM Yun Tang <my...@live.com> wrote:
> I don't think we could use only flink-table-planner-blink related code to
> represent the whole blink branch. There still existed some code changes in
> flink-runtime, flink-streaming-java, flink-yarn and some other modules. However,
> some features are not included in the current flink main branch due to
> some historical reasons.
> From my point of view, as part of the history of Flink community evolution,
> we don't need to drop the blink branch.
>
> Best
> Yun Tang
> ------------------------------
> *From:* Leonard Xu <xb...@gmail.com>
> *Sent:* Wednesday, February 1, 2023 19:27
> *To:* Matthias Pohl <ma...@aiven.io>
> *Cc:* dev@flink.apache.org <de...@flink.apache.org>
> *Subject:* Re: [DISCUSS] Delete useless branches from Flink repository
>
> The blink branch was created when Alibaba contributes its internal Flink
> version to Flink Community, blink related code(e.g.
> flink-table-planner-blink, flink-table-runtime-blink) have been adopted as
> the default code (flink-table-planner, flink-table-runtime)[1], I think we
> can remove it now safely.
>
> Best,
> Leonard
>
> [1] https://issues.apache.org/jira/browse/FLINK-14437
>
>
> > On Feb 1, 2023, at 7:10 PM, Matthias Pohl <ma...@aiven.io>
> wrote:
> >
> > I'm documenting the branches that shouldn't be deleted in the release
> management docs [1]. While going through the remote branches I noticed the
> remote branch blink [2] which was created by Kurt in 2019. It feels like
> that one could be deleted as well.
> >
> > Are there any objections in deleting the blink remote branch? @Leonard
> was there any reason you skipped that one?
> >
> > [1]
> https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management
> <
> https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management
> >
> > [2] https://github.com/apache/flink/tree/blink <
> https://github.com/apache/flink/tree/blink>
> >
> > On Tue, Nov 1, 2022 at 11:26 AM Leonard Xu <xbjtdcq@gmail.com <
> mailto:xbjtdcq@gmail.com <xb...@gmail.com>>> wrote:
> > Thanks Yun Tang for joining the discussion.
> >
> > I’ve deleted these branches with same name tag except
> release-1.14.6-rc2 which has no same name tag.
> >
> > release-1.12.3-rc1
> > release-1.13.2-rc2
> > release-1.14.3-rc1
> > release-1.15.0-rc1
> > release-1.14.6-rc2
> >
> > Best,
> > Leonard
> >
> >
> >
> > >
> > > Hi Leonard,
> > >
> > > Thanks for driving this topic, I think the release candidate branch
> after flink-1.10 could be deleted.
> > >
> > > I believe those branches are created by mistake as the release manager
> should use tags instead of branch to hold the release candidate.
> > > Those branches are:
> > > release-1.12.3-rc1
> > > release-1.13.2-rc2
> > > release-1.14.3-rc1
> > > release-1.14.6-rc2
> > > release-1.15.0-rc1
> > >
> > >
> > > Best
> > > Yun Tang
> > > ________________________________
> > > From: Leonard Xu <xbjtdcq@gmail.com <mailto:xbjtdcq@gmail.com
> <xb...@gmail.com>>>
> > > Sent: Monday, October 31, 2022 20:07
> > > To: dev@flink.apache.org <mailto:dev@flink.apache.org
> <de...@flink.apache.org>> <dev@flink.apache.org <mailto:dev@flink.apache.org
> <de...@flink.apache.org>>>
> > > Subject: Re: [DISCUSS] Delete useless branches from Flink repository
> > >
> > >
> > >> Actually I double checked it and the default branch on jenkins is
> `master`.
> > >
> > > Great, I’ve deleted benchmark-request branch. Now, our repo looks
> better.
> > >
> > > Best,
> > > Leonard
> >
>
>
Re: [DISCUSS] Delete useless branches from Flink repository
Posted by Yun Tang <my...@live.com>.
I don't think we could use only flink-table-planner-blink related code to represent the whole blink branch. There still existed some code changes in flink-runtime, flink-streaming-java, flink-yarn and some other modules. However, some features are not included in the current flink main branch due to some historical reasons.
From my point of view, as part of the history of Flink community evolution, we don't need to drop the blink branch.
Best
Yun Tang
________________________________
From: Leonard Xu <xb...@gmail.com>
Sent: Wednesday, February 1, 2023 19:27
To: Matthias Pohl <ma...@aiven.io>
Cc: dev@flink.apache.org <de...@flink.apache.org>
Subject: Re: [DISCUSS] Delete useless branches from Flink repository
The blink branch was created when Alibaba contributes its internal Flink version to Flink Community, blink related code(e.g. flink-table-planner-blink, flink-table-runtime-blink) have been adopted as the default code (flink-table-planner, flink-table-runtime)[1], I think we can remove it now safely.
Best,
Leonard
[1] https://issues.apache.org/jira/browse/FLINK-14437
> On Feb 1, 2023, at 7:10 PM, Matthias Pohl <ma...@aiven.io> wrote:
>
> I'm documenting the branches that shouldn't be deleted in the release management docs [1]. While going through the remote branches I noticed the remote branch blink [2] which was created by Kurt in 2019. It feels like that one could be deleted as well.
>
> Are there any objections in deleting the blink remote branch? @Leonard was there any reason you skipped that one?
>
> [1] https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management <https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management>
> [2] https://github.com/apache/flink/tree/blink <https://github.com/apache/flink/tree/blink>
>
> On Tue, Nov 1, 2022 at 11:26 AM Leonard Xu <xbjtdcq@gmail.com <ma...@gmail.com>> wrote:
> Thanks Yun Tang for joining the discussion.
>
> I’ve deleted these branches with same name tag except release-1.14.6-rc2 which has no same name tag.
>
> release-1.12.3-rc1
> release-1.13.2-rc2
> release-1.14.3-rc1
> release-1.15.0-rc1
> release-1.14.6-rc2
>
> Best,
> Leonard
>
>
>
> >
> > Hi Leonard,
> >
> > Thanks for driving this topic, I think the release candidate branch after flink-1.10 could be deleted.
> >
> > I believe those branches are created by mistake as the release manager should use tags instead of branch to hold the release candidate.
> > Those branches are:
> > release-1.12.3-rc1
> > release-1.13.2-rc2
> > release-1.14.3-rc1
> > release-1.14.6-rc2
> > release-1.15.0-rc1
> >
> >
> > Best
> > Yun Tang
> > ________________________________
> > From: Leonard Xu <xbjtdcq@gmail.com <ma...@gmail.com>>
> > Sent: Monday, October 31, 2022 20:07
> > To: dev@flink.apache.org <ma...@flink.apache.org> <dev@flink.apache.org <ma...@flink.apache.org>>
> > Subject: Re: [DISCUSS] Delete useless branches from Flink repository
> >
> >
> >> Actually I double checked it and the default branch on jenkins is `master`.
> >
> > Great, I’ve deleted benchmark-request branch. Now, our repo looks better.
> >
> > Best,
> > Leonard
>
Re: [DISCUSS] Delete useless branches from Flink repository
Posted by Leonard Xu <xb...@gmail.com>.
The blink branch was created when Alibaba contributes its internal Flink version to Flink Community, blink related code(e.g. flink-table-planner-blink, flink-table-runtime-blink) have been adopted as the default code (flink-table-planner, flink-table-runtime)[1], I think we can remove it now safely.
Best,
Leonard
[1] https://issues.apache.org/jira/browse/FLINK-14437
> On Feb 1, 2023, at 7:10 PM, Matthias Pohl <ma...@aiven.io> wrote:
>
> I'm documenting the branches that shouldn't be deleted in the release management docs [1]. While going through the remote branches I noticed the remote branch blink [2] which was created by Kurt in 2019. It feels like that one could be deleted as well.
>
> Are there any objections in deleting the blink remote branch? @Leonard was there any reason you skipped that one?
>
> [1] https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management <https://cwiki.apache.org/confluence/display/FLINK/Flink+Release+Management>
> [2] https://github.com/apache/flink/tree/blink <https://github.com/apache/flink/tree/blink>
>
> On Tue, Nov 1, 2022 at 11:26 AM Leonard Xu <xbjtdcq@gmail.com <ma...@gmail.com>> wrote:
> Thanks Yun Tang for joining the discussion.
>
> I’ve deleted these branches with same name tag except release-1.14.6-rc2 which has no same name tag.
>
> release-1.12.3-rc1
> release-1.13.2-rc2
> release-1.14.3-rc1
> release-1.15.0-rc1
> release-1.14.6-rc2
>
> Best,
> Leonard
>
>
>
> >
> > Hi Leonard,
> >
> > Thanks for driving this topic, I think the release candidate branch after flink-1.10 could be deleted.
> >
> > I believe those branches are created by mistake as the release manager should use tags instead of branch to hold the release candidate.
> > Those branches are:
> > release-1.12.3-rc1
> > release-1.13.2-rc2
> > release-1.14.3-rc1
> > release-1.14.6-rc2
> > release-1.15.0-rc1
> >
> >
> > Best
> > Yun Tang
> > ________________________________
> > From: Leonard Xu <xbjtdcq@gmail.com <ma...@gmail.com>>
> > Sent: Monday, October 31, 2022 20:07
> > To: dev@flink.apache.org <ma...@flink.apache.org> <dev@flink.apache.org <ma...@flink.apache.org>>
> > Subject: Re: [DISCUSS] Delete useless branches from Flink repository
> >
> >
> >> Actually I double checked it and the default branch on jenkins is `master`.
> >
> > Great, I’ve deleted benchmark-request branch. Now, our repo looks better.
> >
> > Best,
> > Leonard
>