You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/08 02:32:09 UTC

[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #424: [ISSUE #405]modify the doc

ruanwenjun commented on a change in pull request #424:
URL: https://github.com/apache/incubator-eventmesh/pull/424#discussion_r665824663



##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -44,7 +44,7 @@ sh start.sh
 
 ### 2.1 依赖
 
-同上述步骤 1.1
+同上述步骤 1.1,但是只能在JDK 1.8下构建

Review comment:
       It seems that we have declared the JDK version as 1.8+ in the 1.1 section.

##########
File path: docs/cn/instructions/eventmesh-runtime-quickstart.zh-CN.md
##########
@@ -65,17 +65,7 @@ sh start.sh
 
 > 注:插件模块遵循java spi机制,需要在对应模块中的/main/resources/META-INF/services 下配置相关接口与实现类的映射文件
 
-**2.3.2 配置VM启动参数**
-
-```java
--Dlog4j.configurationFile=eventmesh-runtime/conf/log4j2.xml
--Deventmesh.log.home=eventmesh-runtime/logs
--Deventmesh.home=eventmesh-runtime
--DconfPath=eventmesh-runtime/conf
-```
-> 注:如果操作系统为Windows, 可能需要将文件分隔符换成\
-
-**2.3.3 配置build.gradle文件**
+**2.3.2 配置build.gradle文件**

Review comment:
       The configuration process of plugin has changed, we no longer need to modify the `build.gradle` file and compile again, you can refer to #421.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org