You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/28 06:31:31 UTC

[GitHub] [iceberg] kbendick edited a comment on issue #1954: Avro: Schema conversions should preserve docs

kbendick edited a comment on issue #1954:
URL: https://github.com/apache/iceberg/issues/1954#issuecomment-751593152


   I figured out why the test needed to be updated (slight increase in manifest file size due to the field docs appearing in their header). Given the increase is many orders of magnitude less than the default target manifest file size (698 bytes increase per GenericManifestFile according to my debugger from this patch), I personally don't think it's an issue. I've left a comment on the PR in case anybody wants to weigh in on the slight size increase.
   
   This PR is no longer considered WIP.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org