You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 19:10:10 UTC

[GitHub] [arrow] paleolimbot commented on a diff in pull request #12887: ARROW-16201: [R] SafeCallIntoR on 3.4

paleolimbot commented on code in PR #12887:
URL: https://github.com/apache/arrow/pull/12887#discussion_r850730991


##########
r/tests/testthat/test-safe-call-into-r.R:
##########
@@ -46,6 +46,7 @@ test_that("SafeCallIntoR works within RunWithCapturedR", {
 })
 
 test_that("SafeCallIntoR errors from the non-R thread", {
+  skip_if_r_version("3.4.4")

Review Comment:
   This should still get skipped, but I can also make sure that we error instead of crash `#if !defined(HAS_UNWIND_PROTECT)` (probably more important for https://github.com/apache/arrow/pull/12323 since we'll be actually using it there). Actually, that PR is probably a better place to fix it (I'll make sure to rebase and run the test-r-versions on that PR on Monday).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org