You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/03 15:09:34 UTC
[GitHub] [nifi] turcsanyip opened a new pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
turcsanyip opened a new pull request #5119:
URL: https://github.com/apache/nifi/pull/5119
… processors
https://issues.apache.org/jira/browse/NIFI-8656
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] stan-antyufeev-8451 edited a comment on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
stan-antyufeev-8451 edited a comment on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-856259088
@jfrazee I tested locally and it works for me. I need to promote this fix to our Nifi cluster. Appreciated your work, guys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee closed pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
jfrazee closed pull request #5119:
URL: https://github.com/apache/nifi/pull/5119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] stan-antyufeev-8451 commented on a change in pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
stan-antyufeev-8451 commented on a change in pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#discussion_r646867817
##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/services/azure/storage/TestADLSCredentialsControllerService.java
##########
@@ -327,6 +327,28 @@ public void testGetCredentialsDetailsWithSasToken() throws Exception {
assertNull(actual.getServicePrincipalClientSecret());
}
+ @Test
+ public void testGetCredentialsDetailsWithSasTokenUsingEL() throws Exception {
+ // GIVEN
+ configureAccountName();
+ configureSasTokenUsingEL();
+
+ runner.enableControllerService(credentialsService);
+
+ // WHEN
+ ADLSCredentialsDetails actual = credentialsService.getCredentialsDetails(new HashMap<>());
+
+ // THEN
Review comment:
Hi
Can we merge this change to proceed further? I need this feature to test our on one of the solution built on Nifi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-854069557
@turcsanyip On paper this LGTM. I'll try to give it a test.
This ties into the discussion in #4843 I think, right? So we're walking back the change just for SAS tokens. I think that makes sense and is a good compromise because the use case is a solid one and SAS tokens present much less risk than the access key.
Would it make sense to add more detail to `additionalDetails.html` on the trade offs and maybe suggestions around paying attention to queue and provenance policies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-859773912
@exceptionfactory I'm going to do another pass through this today. Did you have any additional concerns or feedback on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-856240840
@jfrazee Added Additional Details page to explain the security considerations. Feel free to suggest more items that could be worth mentioning.
Also changed the descriptions of some properties because the security concerns regarding EL were displayed for some properties that do not support EL at all.
@exceptionfactory Removed the comments from the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-856191204
@stan-antyufeev-8451 Are you able to or have you given if a test? I'm happy to merge it if so. I can't imagine any issue given the change, but I try to not merge without trying stuff out and hadn't had a chance to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] stan-antyufeev-8451 commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
stan-antyufeev-8451 commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-857732350
@jfrazee Anything else do you have or You can merge to main branch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-859851591
> @exceptionfactory I'm going to do another pass through this today. Did you have any additional concerns or feedback on this?
Thanks for asking @jfrazee, looks good from my perspective, feel free to merge if it looks good to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] stan-antyufeev-8451 commented on a change in pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
stan-antyufeev-8451 commented on a change in pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#discussion_r646867817
##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/services/azure/storage/TestADLSCredentialsControllerService.java
##########
@@ -327,6 +327,28 @@ public void testGetCredentialsDetailsWithSasToken() throws Exception {
assertNull(actual.getServicePrincipalClientSecret());
}
+ @Test
+ public void testGetCredentialsDetailsWithSasTokenUsingEL() throws Exception {
+ // GIVEN
+ configureAccountName();
+ configureSasTokenUsingEL();
+
+ runner.enableControllerService(credentialsService);
+
+ // WHEN
+ ADLSCredentialsDetails actual = credentialsService.getCredentialsDetails(new HashMap<>());
+
+ // THEN
Review comment:
Hi
Can we merge this change to proceed further? I need this feature to test on our one of the solution built on Nifi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#discussion_r645561156
##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/services/azure/storage/TestADLSCredentialsControllerService.java
##########
@@ -327,6 +327,28 @@ public void testGetCredentialsDetailsWithSasToken() throws Exception {
assertNull(actual.getServicePrincipalClientSecret());
}
+ @Test
+ public void testGetCredentialsDetailsWithSasTokenUsingEL() throws Exception {
+ // GIVEN
+ configureAccountName();
+ configureSasTokenUsingEL();
+
+ runner.enableControllerService(credentialsService);
+
+ // WHEN
+ ADLSCredentialsDetails actual = credentialsService.getCredentialsDetails(new HashMap<>());
+
+ // THEN
Review comment:
Although a few tests include the given/when/then comments, I recommend avoiding them for new tests. If there are no other changes, then it is fine to leave them in place, but otherwise I think it would be better to avoid the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] stan-antyufeev-8451 commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
stan-antyufeev-8451 commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-856259088
@jfrazee I tested locally and it works for me. I need to promote this fix to our Nifi cluster. Appreciated you work, guys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #5119: NIFI-8656: Support expression language for SAS Token in the ADLS Gen2…
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #5119:
URL: https://github.com/apache/nifi/pull/5119#issuecomment-854069557
@turcsanyip On paper this LGTM. I'll try to give it a test.
This ties into the discussion in #4843 I think, right? So we're walking back the change just for SAS tokens. I think that makes sense and is a good compromise because the use case is a solid one and SAS tokens present much less risk than the access key.
Would it make sense to add more detail to `additionalDetails.html` on the trade offs and maybe suggestions around paying attention to queue and provenance policies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org