You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/26 17:26:34 UTC

[GitHub] [incubator-mxnet] samskalicky opened a new pull request #20221: [WIP] Reuse params from cached_op_args

samskalicky opened a new pull request #20221:
URL: https://github.com/apache/incubator-mxnet/pull/20221


   ## Description ##
   Reuse the params in `cached_op_args` for subsequent calls to `optimize_for`. Currently, if a new param is added during one call to `optimize_for` it is not available for subsequent calls. For example, if you run multiple graph passes then you would need to export/import to get the param. This PR checks if `cached_op_args` is set and reuses those, otherwise it just calls `collect_params` like normal. 
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Kh4L commented on pull request #20221: [WIP] Reuse params from cached_op_args

Posted by GitBox <gi...@apache.org>.
Kh4L commented on pull request #20221:
URL: https://github.com/apache/incubator-mxnet/pull/20221#issuecomment-827330196


   LGTM! Thanks for the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mseth10 merged pull request #20221: Reuse params from cached_op_args

Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20221:
URL: https://github.com/apache/incubator-mxnet/pull/20221


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Kh4L removed a comment on pull request #20221: [WIP] Reuse params from cached_op_args

Posted by GitBox <gi...@apache.org>.
Kh4L removed a comment on pull request #20221:
URL: https://github.com/apache/incubator-mxnet/pull/20221#issuecomment-827330196


   LGTM! Thanks for the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20221: [WIP] Reuse params from cached_op_args

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20221:
URL: https://github.com/apache/incubator-mxnet/pull/20221#issuecomment-827016259


   Hey @samskalicky , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [unix-gpu, centos-cpu, windows-cpu, unix-cpu, centos-gpu, edge, miscellaneous, website, clang, windows-gpu, sanity]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org