You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/04/10 00:25:32 UTC
Review Request: Fixed AllocatorZookeeperTest to use latest abstractions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10386/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
Removed triggers, updates EXPECT_MESSAGE logic, and moves EXPECT_CALLs closer to actions.
Doesn't include cluster - this is coming in another patch later.
Diffs
-----
src/tests/allocator_zookeeper_tests.cpp cc6e22e
Diff: https://reviews.apache.org/r/10386/diff/
Testing
-------
bin/mesos-tests.sh --gtest_filter=*AllocatorZoo* --gtest_repeat=1000 --gtest_break_on_failure
Thanks,
Thomas Marshall
Re: Review Request: Fixed AllocatorZookeeperTest to use latest abstractions
Posted by Thomas Marshall <tw...@gmail.com>.
> On April 10, 2013, 12:02 a.m., Ben Mahler wrote:
> > src/tests/allocator_zookeeper_tests.cpp, line 151
> > <https://reviews.apache.org/r/10386/diff/1/?file=279889#file279889line151>
> >
> > Does your test rely on this? Maybe you want to be explicit with the test flags?
I'll include a fix for this with the patch that changes these tests to use the new cluster abstraction.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10386/#review18910
-----------------------------------------------------------
On April 9, 2013, 10:25 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10386/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 10:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Removed triggers, updates EXPECT_MESSAGE logic, and moves EXPECT_CALLs closer to actions.
>
> Doesn't include cluster - this is coming in another patch later.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp cc6e22e
>
> Diff: https://reviews.apache.org/r/10386/diff/
>
>
> Testing
> -------
>
> bin/mesos-tests.sh --gtest_filter=*AllocatorZoo* --gtest_repeat=1000 --gtest_break_on_failure
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: Fixed AllocatorZookeeperTest to use latest abstractions
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10386/#review18910
-----------------------------------------------------------
Ship it!
src/tests/allocator_zookeeper_tests.cpp
<https://reviews.apache.org/r/10386/#comment39389>
Does your test rely on this? Maybe you want to be explicit with the test flags?
src/tests/allocator_zookeeper_tests.cpp
<https://reviews.apache.org/r/10386/#comment39390>
ditto
- Ben Mahler
On April 9, 2013, 10:25 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10386/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 10:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Removed triggers, updates EXPECT_MESSAGE logic, and moves EXPECT_CALLs closer to actions.
>
> Doesn't include cluster - this is coming in another patch later.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp cc6e22e
>
> Diff: https://reviews.apache.org/r/10386/diff/
>
>
> Testing
> -------
>
> bin/mesos-tests.sh --gtest_filter=*AllocatorZoo* --gtest_repeat=1000 --gtest_break_on_failure
>
>
> Thanks,
>
> Thomas Marshall
>
>