You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2016/04/05 00:44:05 UTC
Review Request 45712: Global Repeat Tolerance Value For Alerts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-15702
https://issues.apache.org/jira/browse/AMBARI-15702
Repository: ambari
Description
-------
The global repeat tolerance value for all alert definitions is set on the {{cluster-env}} configuration. Unless an alert definition overrides this value, it will be used for any definition in the system. By default, this value will be set to 1, indicating that there is no retry tolerance and the alert state should be taken at face value.
```
GET api/v1/clusters/<cluster>/configurations?type=cluster-env&tag=<tag>
"Config": {
"cluster_name": "c1",
"stack_id": "HDP-2.4"
},
"properties": {
"command_retry_enabled": "true",
"command_retry_max_time_in_sec": "600",
...
"alerts_repeat_tolerance" : "1"
...
}
```
The scope of work must also include
- Default values if the property does not exist
- Ambari upgrade work to ensure it's populated with a default value
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java 951b04b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4c20c6c
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java dec2a33
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 2800ac6
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 38d05ab
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 77e36c8
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9e456eb
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java b3241e0
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java f8a1f64
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java df2ef46
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java ea0547b
Diff: https://reviews.apache.org/r/45712/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 45712: Global Repeat Tolerance Value For Alerts
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/#review126997
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On April 4, 2016, 10:47 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45712/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 10:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-15702
> https://issues.apache.org/jira/browse/AMBARI-15702
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The global repeat tolerance value for all alert definitions is set on the {{cluster-env}} configuration. Unless an alert definition overrides this value, it will be used for any definition in the system. By default, this value will be set to 1, indicating that there is no retry tolerance and the alert state should be taken at face value.
>
> ```
> GET api/v1/clusters/<cluster>/configurations?type=cluster-env&tag=<tag>
>
> "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
> },
> "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
> ...
> }
> ```
>
> The scope of work must also include
> - Default values if the property does not exist
> - Ambari upgrade work to ensure it's populated with a default value
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java 951b04b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4c20c6c
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java dec2a33
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 2800ac6
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 38d05ab
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 77e36c8
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9e456eb
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java b3241e0
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java f8a1f64
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java df2ef46
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java ea0547b
>
> Diff: https://reviews.apache.org/r/45712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 45712: Global Repeat Tolerance Value For Alerts
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/#review126965
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 4, 2016, 10:47 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45712/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 10:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-15702
> https://issues.apache.org/jira/browse/AMBARI-15702
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The global repeat tolerance value for all alert definitions is set on the {{cluster-env}} configuration. Unless an alert definition overrides this value, it will be used for any definition in the system. By default, this value will be set to 1, indicating that there is no retry tolerance and the alert state should be taken at face value.
>
> ```
> GET api/v1/clusters/<cluster>/configurations?type=cluster-env&tag=<tag>
>
> "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
> },
> "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
> ...
> }
> ```
>
> The scope of work must also include
> - Default values if the property does not exist
> - Ambari upgrade work to ensure it's populated with a default value
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java 951b04b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4c20c6c
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java dec2a33
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 2800ac6
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 38d05ab
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 77e36c8
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9e456eb
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java b3241e0
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java f8a1f64
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java df2ef46
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java ea0547b
>
> Diff: https://reviews.apache.org/r/45712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 45712: Global Repeat Tolerance Value For Alerts
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/#review126966
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On April 4, 2016, 6:47 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45712/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 6:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-15702
> https://issues.apache.org/jira/browse/AMBARI-15702
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The global repeat tolerance value for all alert definitions is set on the {{cluster-env}} configuration. Unless an alert definition overrides this value, it will be used for any definition in the system. By default, this value will be set to 1, indicating that there is no retry tolerance and the alert state should be taken at face value.
>
> ```
> GET api/v1/clusters/<cluster>/configurations?type=cluster-env&tag=<tag>
>
> "Config": {
> "cluster_name": "c1",
> "stack_id": "HDP-2.4"
> },
> "properties": {
> "command_retry_enabled": "true",
> "command_retry_max_time_in_sec": "600",
> ...
> "alerts_repeat_tolerance" : "1"
> ...
> }
> ```
>
> The scope of work must also include
> - Default values if the property does not exist
> - Ambari upgrade work to ensure it's populated with a default value
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java 951b04b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4c20c6c
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java dec2a33
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 2800ac6
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 38d05ab
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 77e36c8
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9e456eb
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java b3241e0
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java f8a1f64
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java df2ef46
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java ea0547b
>
> Diff: https://reviews.apache.org/r/45712/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 45712: Global Repeat Tolerance Value For Alerts
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/
-----------------------------------------------------------
(Updated April 4, 2016, 6:47 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-15702
https://issues.apache.org/jira/browse/AMBARI-15702
Repository: ambari
Description
-------
The global repeat tolerance value for all alert definitions is set on the {{cluster-env}} configuration. Unless an alert definition overrides this value, it will be used for any definition in the system. By default, this value will be set to 1, indicating that there is no retry tolerance and the alert state should be taken at face value.
```
GET api/v1/clusters/<cluster>/configurations?type=cluster-env&tag=<tag>
"Config": {
"cluster_name": "c1",
"stack_id": "HDP-2.4"
},
"properties": {
"command_retry_enabled": "true",
"command_retry_max_time_in_sec": "600",
...
"alerts_repeat_tolerance" : "1"
...
}
```
The scope of work must also include
- Default values if the property does not exist
- Ambari upgrade work to ensure it's populated with a default value
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/RecoveryConfigHelper.java 951b04b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java 4c20c6c
ambari-server/src/main/java/org/apache/ambari/server/events/ClusterConfigChangedEvent.java dec2a33
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java 2800ac6
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 38d05ab
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 77e36c8
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 9e456eb
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java b3241e0
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java f8a1f64
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java df2ef46
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java ea0547b
Diff: https://reviews.apache.org/r/45712/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley