You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/22 11:29:32 UTC

[GitHub] [spark] LuciferYang edited a comment on pull request #29836: [SPARK-32964][CORE][DSTREAMS] Pass all `streaming` module UTs in Scala 2.13

LuciferYang edited a comment on pull request #29836:
URL: https://github.com/apache/spark/pull/29836#issuecomment-696662269


   https://github.com/apache/spark/blob/790d9ef2d3a90388ef3c36d5ae47b2fe369a83ba/core/src/main/scala/org/apache/spark/serializer/SerializationDebugger.scala#L84-L108
   
   `ArrayBuffer` will matched `Array` branch in Scala 2.12, but matched `Object with java.io.Serializable` in Scala 2.13, and it wrapped to `DefaultSerializationProxy` , `ModuleSerializationProxy` and `IterableFactory` in this  scene. 
   
   For simplicity, I've chosen to modify  `DStreamGraph` to avoid these problems,  but I'm not sure if it will seriously affect performance.
   
   cc @srowen Is there a better way to fix this problem? thx ~
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org