You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/07/20 00:25:45 UTC
[GitHub] [helix] zhangmeng916 opened a new issue #1156: Fix invalid session id in TestRebalancePipeline (testDuplicateMsg)
zhangmeng916 opened a new issue #1156:
URL: https://github.com/apache/helix/issues/1156
In the test `testDuplicateMsg` from TestRebalancePipeline, currently an invalid session id is used. Here's the detail:
setCurrentState(clusterName, "localhost_0", resourceName, resourceName + "_0", "session_1", "SLAVE");
"session_1" is not the correct session id and we should use `liveInstances.get(0).getEphemeralOwner()` instead. The wrong session id makes the following test and assertion meaningless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly closed issue #1156: Fix invalid session id in TestRebalancePipeline (testDuplicateMsg)
Posted by GitBox <gi...@apache.org>.
narendly closed issue #1156:
URL: https://github.com/apache/helix/issues/1156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org