You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/03 10:10:49 UTC
[GitHub] [pulsar] labuladong commented on a diff in pull request #18318: [fix][flaky] fix testEndTxnWhenCommittingOrAborting flaky test
labuladong commented on code in PR #18318:
URL: https://github.com/apache/pulsar/pull/18318#discussion_r1012707750
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java:
##########
@@ -343,9 +343,6 @@ public void sendEndTxnErrorResponse(long requestId, TxnID txnID, ServerError err
safeIntercept(command, cnx);
ByteBuf outBuf = Commands.serializeWithSize(command);
cnx.ctx().writeAndFlush(outBuf, cnx.ctx().voidPromise());
- if (this.interceptor != null) {
- this.interceptor.txnEnded(txnID.toString(), TxnAction.ABORT_VALUE);
- }
Review Comment:
Why do we need to delete this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org