[GitHub] [iceberg] rdblue commented on a change in pull request #3998: Flink: Support override write configuration on top of table properties in FlinkSink builder

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3998:
URL: https://github.com/apache/iceberg/pull/3998#discussion_r810203572



##########
File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -442,6 +455,16 @@ private String operatorName(String suffix) {
           throw new RuntimeException("Unrecognized write.distribution-mode: " + writeMode);
       }
     }
+
+    private void buildProperties() {

Review comment:
       I think this should accept a Table instance and return a merged properties map.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org