[GitHub] [arrow-rs] viirya commented on a diff in pull request #2160: parquet reader: Support reading decimals from parquet `BYTE_ARRAY` type

[GitBox <gi...@apache.org>]

viirya commented on code in PR #2160:
URL: https://github.com/apache/arrow-rs/pull/2160#discussion_r929243909


##########
parquet/src/arrow/array_reader/builder.rs:
##########
@@ -233,6 +225,18 @@ fn build_primitive_reader(
                 column_desc,
                 arrow_type,
             ),
+            Some(DataType::Decimal(precision, scale)) => {
+                // read decimal data from parquet binary physical type
+                let convert = DecimalByteArrayConvert::new(DecimalArrayConverter::new(precision as i32, scale as i32));
+                Ok(Box::new(
+                    ComplexObjectArrayReader::<ByteArrayType,DecimalByteArrayConvert>::new(

Review Comment:
   style?
   
   ```suggestion
                       ComplexObjectArrayReader::<ByteArrayType, DecimalByteArrayConvert>::new(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org