You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/10/20 22:54:00 UTC
[kudu-CR] types: Correct printable name of UNIXTIME MICROS
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4777
Change subject: types: Correct printable name of UNIXTIME_MICROS
......................................................................
types: Correct printable name of UNIXTIME_MICROS
UNIXTIME_MICROS is still printing "timestamp" in some errors. This
patch fixes that.
Change-Id: I84b5dc52c3f3ee311330c5151d380b34e13a34ae
---
M src/kudu/common/types.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4777/1
--
To view, visit http://gerrit.cloudera.org:8080/4777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84b5dc52c3f3ee311330c5151d380b34e13a34ae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] types: Correct printable name of UNIXTIME MICROS
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: types: Correct printable name of UNIXTIME_MICROS
......................................................................
types: Correct printable name of UNIXTIME_MICROS
UNIXTIME_MICROS is still printing "timestamp" in some errors. This
patch fixes that.
Change-Id: I84b5dc52c3f3ee311330c5151d380b34e13a34ae
Reviewed-on: http://gerrit.cloudera.org:8080/4777
Tested-by: Kudu Jenkins
Reviewed-by: Dinesh Bhat <di...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/common/types.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dinesh Bhat: Looks good to me, but someone else must approve
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84b5dc52c3f3ee311330c5151d380b34e13a34ae
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] types: Correct printable name of UNIXTIME MICROS
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: types: Correct printable name of UNIXTIME_MICROS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84b5dc52c3f3ee311330c5151d380b34e13a34ae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] types: Correct printable name of UNIXTIME MICROS
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: types: Correct printable name of UNIXTIME_MICROS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84b5dc52c3f3ee311330c5151d380b34e13a34ae
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No