You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/28 18:43:40 UTC

[GitHub] [airflow] josh-fell opened a new pull request #19865: Update `default_args` value in example_functions DAG from str to int

josh-fell opened a new pull request #19865:
URL: https://github.com/apache/airflow/pull/19865


   As part of #19803 the `retries` value in the "example_functions" DAG within the Google provider was improperly added as a string rather than an integer. This update yields the below warnings in CI when importing all Airflow classes:
   ```
    Importing package: airflow.providers.google.cloud.example_dags
     [2021-11-28 18:30:01,419] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionDeployFunctionOperator): gcf_deploy_task> from '\x1b[01m3\x1b[22m' to int
     [2021-11-28 18:30:01,421] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionDeployFunctionOperator): gcf_deploy2_task> from '\x1b[01m3\x1b[22m' to int
     [2021-11-28 18:30:01,422] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionInvokeFunctionOperator): invoke_task> from '\x1b[01m3\x1b[22m' to int
     [2021-11-28 18:30:01,424] {baseoperator.py:607} WARNING - Implicitly converting 'retries' for <Task(CloudFunctionDeleteFunctionOperator): gcf_delete_task> from '\x1b[01m3\x1b[22m' to int
   ```
   This PR updates the datatype of the `retries` value.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal merged pull request #19865: Fix CI warnings when importing Google provider example DAGs

Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #19865:
URL: https://github.com/apache/airflow/pull/19865


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #19865: Fix CI warnings when importing Google provider example DAGs

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19865:
URL: https://github.com/apache/airflow/pull/19865#issuecomment-981146170


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org