You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/30 22:20:30 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #7602: ARROW-9083: [R] collect int64, uint32, uint64 as R integer type if not out of bounds
nealrichardson opened a new pull request #7602:
URL: https://github.com/apache/arrow/pull/7602
Still to do:
- [ ] Update test expectations since the output types have changed
- [ ] Add tests that exercise the case where the data doesn't fit into int32
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #7602: ARROW-9083: [R] collect int64, uint32, uint64 as R integer type if not out of bounds
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #7602:
URL: https://github.com/apache/arrow/pull/7602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7602: ARROW-9083: [R] collect int64, uint32, uint64 as R integer type if not out of bounds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7602:
URL: https://github.com/apache/arrow/pull/7602#issuecomment-652080559
https://issues.apache.org/jira/browse/ARROW-9083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on a change in pull request #7602: ARROW-9083: [R] collect int64, uint32, uint64 as R integer type if not out of bounds
Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #7602:
URL: https://github.com/apache/arrow/pull/7602#discussion_r448028250
##########
File path: r/src/array_to_vector.cpp
##########
@@ -673,6 +676,17 @@ class Converter_Null : public Converter {
}
};
+bool arrays_can_fit_integer(ArrayVector arrays) {
Review comment:
nit: not sure if it's worth the effort of following the C++ guide viz-a-viz function naming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org