[jira] [Commented] (HIVE-22414) Make LLAP CacheTags more memory efficient

["Hive QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-22414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966612#comment-16966612 ] 

Hive QA commented on HIVE-22414:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12984772/HIVE-22414.3.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17546 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_overwrite] (batchId=166)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19279/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19279/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19279/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12984772 - PreCommit-HIVE-Build

> Make LLAP CacheTags more memory efficient
> -----------------------------------------
>
>                 Key: HIVE-22414
>                 URL: https://issues.apache.org/jira/browse/HIVE-22414
>             Project: Hive
>          Issue Type: Improvement
>          Components: llap
>            Reporter: Ádám Szita
>            Assignee: Ádám Szita
>            Priority: Major
>         Attachments: HIVE-22414.0.patch, HIVE-22414.1.patch, HIVE-22414.2.patch, HIVE-22414.3.patch
>
>
> MultiPartitionCacheTag relies on LinkedLists.
> A LinkedList object that holds e.g. 2 nodes consumes 112 bytes roughly in this composition:
>  * 16 bytes for LinkedList object header
>  * 8 bytes for referring head
>  * 8 bytes for referring tail
>  * 80 = 2 x (16 bytes for LinkedList$Node header, 3 x 8 bytes for referring prev, next, item)
> This is a lot, so I propose to replace LinkedList in MultiPartitionCacheTag with a simple String array. (For a similar scenario an array would take 16 + 8 + 2 x 8 = 40 bytes, as per header, count, and 2 references for our actual objects).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)