You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/17 08:28:04 UTC

[GitHub] [rocketmq] drpmma commented on a diff in pull request #4615: [ISSUE #3905] Support bname in protocol

drpmma commented on code in PR #4615:
URL: https://github.com/apache/rocketmq/pull/4615#discussion_r922795300


##########
client/src/main/java/org/apache/rocketmq/client/consumer/store/RemoteBrokerOffsetStore.java:
##########
@@ -213,6 +213,7 @@ public void updateConsumeOffsetToBroker(MessageQueue mq, long offset, boolean is
             requestHeader.setConsumerGroup(this.groupName);
             requestHeader.setQueueId(mq.getQueueId());
             requestHeader.setCommitOffset(offset);
+            requestHeader.setBname(mq.getBrokerName());

Review Comment:
   The `bname` is not in the scope of this pr, see b6ff649291453d3dc2d702fbba1548d991b610ac for more information.
   
   I guess `bname` is shorter than `brokerName` thus it is more efficient in tranport.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org