[GitHub] ivankelly commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API

[gi...@git.apache.org]

ivankelly commented on a change in pull request #510: Issue-605 BP-15 New CreateLedger API
URL: https://github.com/apache/bookkeeper/pull/510#discussion_r139000838
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
 ##########
 @@ -39,21 +43,21 @@
  * Encapsulates the ledger open operation
  *
  */
-class LedgerOpenOp implements GenericCallback<LedgerMetadata> {
+class LedgerOpenOp implements GenericCallback<LedgerMetadata>, OpenBuilder {
     static final Logger LOG = LoggerFactory.getLogger(LedgerOpenOp.class);
 
     final BookKeeper bk;
-    final long ledgerId;
 
 Review comment:
   separate the builder code from the op code. It serves a different end and makes the business logic less clear.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services