You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by NathanHowell <gi...@git.apache.org> on 2017/03/12 17:34:33 UTC

[GitHub] spark pull request #17255: [SPARK-19918][SQL] Use TextFileFormat in implemen...

Github user NathanHowell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17255#discussion_r105563532
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonDataSource.scala ---
    @@ -23,24 +23,25 @@ import com.fasterxml.jackson.core.{JsonFactory, JsonParser}
     import com.google.common.io.ByteStreams
     import org.apache.hadoop.conf.Configuration
     import org.apache.hadoop.fs.FileStatus
    -import org.apache.hadoop.io.{LongWritable, Text}
    +import org.apache.hadoop.io.Text
     import org.apache.hadoop.mapreduce.Job
    -import org.apache.hadoop.mapreduce.lib.input.{FileInputFormat, TextInputFormat}
    +import org.apache.hadoop.mapreduce.lib.input.FileInputFormat
     
     import org.apache.spark.TaskContext
     import org.apache.spark.input.{PortableDataStream, StreamInputFormat}
     import org.apache.spark.rdd.{BinaryFileRDD, RDD}
    -import org.apache.spark.sql.{AnalysisException, SparkSession}
    +import org.apache.spark.sql.{AnalysisException, Encoders, SparkSession}
    --- End diff --
    
    Is the `Encoders` import still necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org