You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2009/01/29 00:10:59 UTC

[jira] Commented: (HADOOP-5139) RPC call throws IllegalArgumentException complaining duplicate metrics registration

    [ https://issues.apache.org/jira/browse/HADOOP-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668215#action_12668215 ] 

Hairong Kuang commented on HADOOP-5139:
---------------------------------------

The problem is that the RPC server first checks if a metrics is registered; if no, it then register the metrics. However, check/register is not synchronized. So although the first check reports the metrics is not registered, the metrics may be registered by another thread before this thread registers it.

I propose that IPC server catches the exception and fetches the metrics handle again.

> RPC call throws IllegalArgumentException complaining duplicate metrics registration
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-5139
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5139
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: ipc
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.19.1
>
>
> Here is the error log:
>     INFO  ipc.Server (Server.java:run(968)) - IPC Server handler 7 on 51017, call addBlock(/file7, DFSClient_-2132593831) from 127.0.0.1:51030: error: java.io.IOException: java.lang.IllegalArgumentException: Duplicate metricsName:addBlock
>     java.io.IOException: java.lang.IllegalArgumentException: DuplicatemetricsName:addBlock
>          at org.apache.hadoop.metrics.util.MetricsRegistry.add(MetricsRegistry.java:56)
>          at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:89)
>          at org.apache.hadoop.metrics.util.MetricsTimeVaryingRate.<init>(MetricsTimeVaryingRate.java:99)
>          at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:522)
>          at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:959)
>          at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:955)
>          at java.security.AccessController.doPrivileged(Native Method)
>          at javax.security.auth.Subject.doAs(Subject.java:396)
>          at org.apache.hadoop.ipc.Server$Handler.run(Server.java:953)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.