You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by br...@apache.org on 2025/08/27 10:06:03 UTC
(activemq-artemis) branch main updated: ARTEMIS-5639 fix MQTTRetainMessageManagerTest
This is an automated email from the ASF dual-hosted git repository.
brusdev pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
The following commit(s) were added to refs/heads/main by this push:
new dfeee9d8cd ARTEMIS-5639 fix MQTTRetainMessageManagerTest
dfeee9d8cd is described below
commit dfeee9d8cde2bcdcad1ad485ad6eddcbae66093b
Author: Justin Bertram <jb...@apache.org>
AuthorDate: Tue Aug 26 22:49:04 2025 -0500
ARTEMIS-5639 fix MQTTRetainMessageManagerTest
---
.../mqtt5/MQTTRetainMessageManagerTest.java | 27 ++++++++++++++--------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTTRetainMessageManagerTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTTRetainMessageManagerTest.java
index dba736c01e..da6d081a19 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTTRetainMessageManagerTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/MQTTRetainMessageManagerTest.java
@@ -18,6 +18,7 @@ import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.fail;
+import java.nio.charset.StandardCharsets;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;
import java.util.stream.IntStream;
@@ -142,7 +143,7 @@ public class MQTTRetainMessageManagerTest extends MQTT5TestSupport {
final MqttMessage message = new MqttMessage();
message.setQos(qos);
message.setRetained(true);
- message.setPayload(RandomUtil.randomBytes(128));
+ message.setPayload(RandomUtil.randomUUIDString().getBytes(StandardCharsets.UTF_8));
mqttPublisher.publish(topic, message);
lastMessagePublished.set(message);
}
@@ -153,15 +154,21 @@ public class MQTTRetainMessageManagerTest extends MQTT5TestSupport {
Wait.waitFor(() -> lastMessageArrivedOnConsumerAfterPublish2.get() != null, 5000, 100);
assertEquals(1, arrivedCountAferPublish.get());
- assertArrayEquals(lastMessagePublished.get().getPayload(), lastMessageArrivedOnConsumerBeforePublish.get().getPayload(), String.format(
- "\nMessage arrived on consumer subscribed before the publish is different from the last published message!\nPublished: %s\nArrived : %s\n",
- new String(lastMessagePublished.get().getPayload()), new String(lastMessageArrivedOnConsumerAfterPublish.get().getPayload())));
- assertArrayEquals(lastMessagePublished.get().getPayload(), lastMessageArrivedOnConsumerAfterPublish.get().getPayload(), String.format(
- "\nMessage arrived on consumer subscribed after the publish is different from the last published message!\nPublished: %s\nArrived : %s\n",
- new String(lastMessagePublished.get().getPayload()), new String(lastMessageArrivedOnConsumerAfterPublish.get().getPayload())));
- assertArrayEquals(lastMessagePublished.get().getPayload(), lastMessageArrivedOnConsumerAfterPublish2.get().getPayload(), String.format(
- "\nMessage arrived on consumer subscribed after the publish (2) is different from the last published message!\nPublished: %s\nArrived : %s\n",
- new String(lastMessagePublished.get().getPayload()), new String(lastMessageArrivedOnConsumerAfterPublish.get().getPayload())));
+ assertArrayEquals(lastMessagePublished.get().getPayload(),
+ lastMessageArrivedOnConsumerBeforePublish.get().getPayload(),
+ String.format("\nMessage that arrived on consumer subscribed before the publish is different from the last published message!\nPublished: %s\nArrived : %s\n",
+ new String(lastMessagePublished.get().getPayload(), StandardCharsets.UTF_8),
+ new String(lastMessageArrivedOnConsumerBeforePublish.get().getPayload(), StandardCharsets.UTF_8)));
+ assertArrayEquals(lastMessagePublished.get().getPayload(),
+ lastMessageArrivedOnConsumerAfterPublish.get().getPayload(),
+ String.format("\nMessage that arrived on consumer subscribed after the publish is different from the last published message!\nPublished: %s\nArrived : %s\n",
+ new String(lastMessagePublished.get().getPayload(), StandardCharsets.UTF_8),
+ new String(lastMessageArrivedOnConsumerAfterPublish.get().getPayload(), StandardCharsets.UTF_8)));
+ assertArrayEquals(lastMessagePublished.get().getPayload(),
+ lastMessageArrivedOnConsumerAfterPublish2.get().getPayload(),
+ String.format("\nMessage that arrived on consumer subscribed after the publish (2) is different from the last published message!\nPublished: %s\nArrived : %s\n",
+ new String(lastMessagePublished.get().getPayload(), StandardCharsets.UTF_8),
+ new String(lastMessageArrivedOnConsumerAfterPublish2.get().getPayload(), StandardCharsets.UTF_8)));
} catch (MqttException e) {
fail(e.getMessage());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@activemq.apache.org
For additional commands, e-mail: commits-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact