[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #75: Add "f" as the short filename

[GitBox <gi...@apache.org>]

rm5248 commented on a change in pull request #75:
URL: https://github.com/apache/logging-log4cxx/pull/75#discussion_r756944581



##########
File path: src/main/cpp/locationinfo.cpp
##########
@@ -102,6 +120,14 @@ const char* LocationInfo::getFileName() const
 	return fileName;
 }
 
+/**
+ *   Return the short file name of the caller.
+ *   @returns file name, may be null.
+ */
+const std::string LocationInfo::getShortFileName() const{

Review comment:
       This should probably be a `const char*` for consistency.  There's a probably slightly more efficient way to do this as well without relying on `std::string`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org