You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/07/07 22:10:51 UTC
[jira] Created: (MPXDOC-114) cvs-usage presumes pserve protocol on
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Wed, 7 Jul 2004 4:10 PM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Dennis Lundberg (mailto:dennis.lundberg@mdh.se)
Date: Sat, 24 Jul 2004 9:49 AM
Comment:
This patch is for maven-core.
Changes:
Attachment changed to Repository.java.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPXDOC-114?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sat, 24 Jul 2004 9:49 AM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-114?page=all ]
Arnaud Heritier updated MPXDOC-114:
-----------------------------------
Assign To: (was: Arnaud Heritier)
> cvs-usage presumes pserve protocol on <connection>
> --------------------------------------------------
>
> Key: MPXDOC-114
> URL: http://jira.codehaus.org/browse/MPXDOC-114
> Project: maven-xdoc-plugin
> Type: Bug
> Reporter: Erik Husby
> Attachments: Repository.java.patch, cvs-usage.xml.patch, maven-plugins.patch, maven.patch
>
>
> The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
> 1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
> 2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
> 3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
> The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
> Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
> Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
> Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Brett Porter
Created: Fri, 30 Jul 2004 10:18 AM
Body:
Assuming the patch works, I'm happy for it to be applied as-is to Maven 1.0.1. The Project will be overhauled in Maven 1.1.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22528
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Fri, 30 Jul 2004 10:18 AM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Dennis Lundberg
Created: Sun, 25 Jul 2004 6:24 AM
Body:
These sound like good ideas to me too. It felt rather strange having to patch maven-core because of something that is only needed in one plugin.
1) Separate the scm reports from the xdoc plugin and move them to the scm plugin.
This is something that I'm not sure I know how to do, yet...
2) Keep the gleaning of CVS info out of the org.apache.maven.project.Repository class and place it in a class in the SCM plugin
So would we have something like o.a.m.scm.cvs.Repository extends o.a.m.project.Repository or maybe o.a.m.scm.CvsRepository extends o.a.m.project.Repository?
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22277
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sun, 25 Jul 2004 6:24 AM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Sun, 25 Jul 2004 10:22 PM
Body:
Separate the scm reports from the xdoc plugin:
We need new goals in the SCM project to register, perform and deregister the report.
Keep the gleaning of CVS info out of the org.apache.maven.project.Repository class:
"So would we have something like o.a.m.scm.cvs.Repository extends o.a.m.project.Repository or maybe o.a.m.scm.CvsRepository extends o.a.m.project.Repository?"
I'd rather we have a factory class in the SCM project that doesn't extend Repository, but uses it to create an SCM specific class, e.g. your CVS repo object above, which is data only, i.e. not tied to Repository
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22313
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sun, 25 Jul 2004 10:22 PM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Tue, 3 Aug 2004 2:37 AM
Body:
"The problem I have now is that this really isn't a "report", it is a "Project Info" menu item in the navigation. But I now have it under "Project Reports" instead. What can be done about that? Do we need a mechanism in the xdoc-plugin to register such items as well as reports?"
Yes, we do...
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22672
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Tue, 3 Aug 2004 2:37 AM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Dennis Lundberg (mailto:dennis.lundberg@mdh.se)
Date: Sat, 24 Jul 2004 9:48 AM
Comment:
This patch is for maven-xdoc-plugin.
Changes:
Attachment changed to cvs-usage.xml.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPXDOC-114?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sat, 24 Jul 2004 9:48 AM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Dennis Lundberg
Created: Tue, 27 Jul 2004 7:19 PM
Body:
1. Separate the scm reports from the xdoc plugin:
OK, I have managed to get the SCM plugin to register, create the report and deregister. The problem I have now is that this really isn't a "report", it is a "Project Info" menu item in the navigation. But I now have it under "Project Reports" instead. What can be done about that? Do we need a mechanism in the xdoc-plugin to register such items as well as reports?
2. Keep the gleaning of CVS info out of the org.apache.maven.project.Repository class:
I thought about this some more and came to the same conclusion as you, with regards to using a factory class in the SCM plugin. We should also keep o.a.m.project.Repository clean of any cvs-specific methods. But I still think that we need getScmType() and getDeveloperScmType() in there. At least for the now. Do you agree?
getDeveloperScmType() is missing right now. One of the fixes for this issue requires it. My patch Repository.java.patch fixes it. Should I open an issue for this in Maven instead of keeping it in this plugin?
Beeing new to the maven developer comunity I don't know how the workload between maven and the plugins is divided. Are there different developers working on maven than on the plugins, or do you work all over the place?
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22418
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Tue, 27 Jul 2004 7:19 PM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPXDOC-114?page=all ]
Lukas Theussl closed MPXDOC-114:
--------------------------------
Resolution: Fixed
Fix Version: 1.10
Fixed with MPXDOC-130
> cvs-usage presumes pserve protocol on <connection>
> --------------------------------------------------
>
> Key: MPXDOC-114
> URL: http://jira.codehaus.org/browse/MPXDOC-114
> Project: maven-xdoc-plugin
> Type: Bug
> Reporter: Erik Husby
> Fix For: 1.10
> Attachments: Repository.java.patch, cvs-usage.xml.patch, maven-plugins.patch, maven.patch
>
>
> The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
> 1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
> 2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
> 3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
> The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
> Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
> Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
> Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Dennis Lundberg
Created: Sat, 24 Jul 2004 9:47 AM
Body:
I have found the reason why 2 happens.
In the file
maven-plugins/xdoc/src/plugin-resources/templates/cvs-usage.xml
on line 90 we do
#set ($connscm = $repository.getScmType())
A look inside the class
org.apache.maven.project.Repository
shows that the method getScmType() returns the type for the non-developer-connection. In the scenario for this issue that would be very empty. So it seems that there is a need for something like this in that class:
/**
* Get the SCM type for developers
*/
public String getDeveloperScmType() {
if ( isValid( getDeveloperConnection() ) )
{
return splitSCMConnection(getDeveloperConnection())[1];
}
return null;
}
One would the change the line in cvs-usage.xml to
#set ($connscm = $repository.geDevelopertScmType())
I will be adding patches shortly but since I have not yet tried building Maven from source, I can not confirm that they actually work.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22255
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sat, 24 Jul 2004 9:47 AM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Dennis Lundberg
Created: Fri, 30 Jul 2004 4:13 PM
Body:
To solve 2 the patch "Repository.java.patch" needs to be applied to Maven and the patch "cvs-usage.xml.patch" needs to be applied to the xdoc plugin.
I can make an alternate patch for 1 that only involves changes to the xdoc plugin - just remove the "pserver" text bits. The protocol is shown on the next line in the report anyway.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22555
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Fri, 30 Jul 2004 4:13 PM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Sun, 25 Jul 2004 2:33 AM
Body:
I'd prefer we:
1) Separate the scm reports from the xdoc plugin and move them to the scm plugin.
2) Keep the gleaning of CVS info out of the org.apache.maven.project.Repository class and place it in a class in the SCM plugin
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPXDOC-114?page=comments#action_22274
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sun, 25 Jul 2004 2:33 AM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Dennis Lundberg (mailto:dennis.lundberg@mdh.se)
Date: Sat, 24 Jul 2004 1:12 PM
Comment:
Here's a new patch for maven-xdoc-plugin. This one has been tested. It solves problems 1 and 2.
Contents:
- Removed the text "(pserver)" in two places
- Prints the username defined in the repository-connection instead of always using "anonymous"
- Make sure the developerConnection sections show even if no connection has been defined in the repository tag
This patch (maven-plugins.patch) requires that maven.patch is applied to Maven.
Changes:
Attachment changed to maven-plugins.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPXDOC-114?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sat, 24 Jul 2004 1:12 PM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPXDOC-114) cvs-usage presumes pserve protocol on
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Dennis Lundberg (mailto:dennis.lundberg@mdh.se)
Date: Sat, 24 Jul 2004 1:04 PM
Comment:
Here's a new patch for Maven. This time it has been tested (yes, I got the bootstrap-thingy working).
Contents:
- Adds getDeveloperScmType() to o.a.m.project.Repository
- Adds getCvsUsername() to o.a.m.project.Repository
- Adds Unittest for getCvsUsername()
Changes:
Attachment changed to maven.patch
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPXDOC-114?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPXDOC-114
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPXDOC-114
Summary: cvs-usage presumes pserve protocol on <connection>
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-xdoc-plugin
Assignee: Jason van Zyl
Reporter: Erik Husby
Created: Wed, 7 Jul 2004 4:10 PM
Updated: Sat, 24 Jul 2004 1:04 PM
Description:
The Repository report makes some assumptions about ones use of cvs that are not necessarily true.
1. The pom.repository.connection is assumed to be the pserve protocol. Not true for our in-house projects.
2. The pom.repository.developerConnection is only displayed when there is a pom.repository.connection entry. The two fields are not connected.
3. The CVS Access behind firewall is always included if pom.repository.connection is specified. This is not true in our in-house environment.
The changelog report works fine if only pom.repository.developerConnection is specified, I would like to not specify pom.repository.connnection
Problem#1 can be addressed by examinging the cvs protocol and adjusting the comments.
Problem#2 I experimented with modifing the cvs-usage.xml but not being knowledge in velocity, I could not see why problem #2 occurs.
Problem#3 can be solved in a number of ways from an addition to the pom.repository or by an additional maven-xdoc-plugin property.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org