You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2018/05/25 10:21:08 UTC
Review Request 67320: Sent task (health) check updates over the
operator streaming API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/
-----------------------------------------------------------
Review request for mesos and Zhitao Li.
Repository: mesos
Description
-------
With this patch subscribers to the master operator streaming API
start receiving task health (check) updates. This allows subscribers
to maintain more accurate view of the cluster's state, closer to
what the traditional `state.json` endpoint offers.
Diffs
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
Diff: https://reviews.apache.org/r/67320/diff/1/
Testing
-------
make check on
* Mac OS 10.13.4
* [pending] various linux distros
Thanks,
Alexander Rukletsov
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review203885
-----------------------------------------------------------
src/tests/api_tests.cpp
Lines 2386 (patched)
<https://reviews.apache.org/r/67320/#comment286238>
We typically do not do `this->`.
`Try<Owned<cluster::Master>> master = StartMaster();`
- Zhitao Li
On May 25, 2018, 6:52 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67320/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 6:52 a.m.)
>
>
> Review request for mesos and Zhitao Li.
>
>
> Bugs: MESOS-8942
> https://issues.apache.org/jira/browse/MESOS-8942
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch subscribers to the master operator streaming API
> start receiving task health (check) updates. This allows subscribers
> to maintain more accurate view of the cluster's state, closer to
> what the traditional `state.json` endpoint offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67320/diff/1/
>
>
> Testing
> -------
>
> make check on
> * Mac OS 10.13.4
> * various linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review204026
-----------------------------------------------------------
PASS: Mesos patch 67320 was successfully built and tested.
Reviews applied: `['67320']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67320
- Mesos Reviewbot Windows
On May 28, 2018, 11:25 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67320/
> -----------------------------------------------------------
>
> (Updated May 28, 2018, 11:25 a.m.)
>
>
> Review request for mesos and Zhitao Li.
>
>
> Bugs: MESOS-8942
> https://issues.apache.org/jira/browse/MESOS-8942
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch subscribers to the master operator streaming API
> start receiving task health (check) updates. This allows subscribers
> to maintain more accurate view of the cluster's state, closer to
> what the traditional `state.json` endpoint offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67320/diff/2/
>
>
> Testing
> -------
>
> make check on
> * Mac OS 10.13.4
> * various linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review204023
-----------------------------------------------------------
Ship it!
Ship It!
- Zhitao Li
On May 28, 2018, 4:25 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67320/
> -----------------------------------------------------------
>
> (Updated May 28, 2018, 4:25 a.m.)
>
>
> Review request for mesos and Zhitao Li.
>
>
> Bugs: MESOS-8942
> https://issues.apache.org/jira/browse/MESOS-8942
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch subscribers to the master operator streaming API
> start receiving task health (check) updates. This allows subscribers
> to maintain more accurate view of the cluster's state, closer to
> what the traditional `state.json` endpoint offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67320/diff/2/
>
>
> Testing
> -------
>
> make check on
> * Mac OS 10.13.4
> * various linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/
-----------------------------------------------------------
(Updated May 28, 2018, 11:25 a.m.)
Review request for mesos and Zhitao Li.
Bugs: MESOS-8942
https://issues.apache.org/jira/browse/MESOS-8942
Repository: mesos
Description
-------
With this patch subscribers to the master operator streaming API
start receiving task health (check) updates. This allows subscribers
to maintain more accurate view of the cluster's state, closer to
what the traditional `state.json` endpoint offers.
Diffs (updated)
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
Diff: https://reviews.apache.org/r/67320/diff/2/
Changes: https://reviews.apache.org/r/67320/diff/1-2/
Testing
-------
make check on
* Mac OS 10.13.4
* various linux distros
Thanks,
Alexander Rukletsov
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/
-----------------------------------------------------------
(Updated May 25, 2018, 1:52 p.m.)
Review request for mesos and Zhitao Li.
Bugs: MESOS-8942
https://issues.apache.org/jira/browse/MESOS-8942
Repository: mesos
Description
-------
With this patch subscribers to the master operator streaming API
start receiving task health (check) updates. This allows subscribers
to maintain more accurate view of the cluster's state, closer to
what the traditional `state.json` endpoint offers.
Diffs
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
Diff: https://reviews.apache.org/r/67320/diff/1/
Testing
-------
make check on
* Mac OS 10.13.4
* various linux distros
Thanks,
Alexander Rukletsov
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/
-----------------------------------------------------------
(Updated May 25, 2018, 1:51 p.m.)
Review request for mesos and Zhitao Li.
Repository: mesos
Description
-------
With this patch subscribers to the master operator streaming API
start receiving task health (check) updates. This allows subscribers
to maintain more accurate view of the cluster's state, closer to
what the traditional `state.json` endpoint offers.
Diffs
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
Diff: https://reviews.apache.org/r/67320/diff/1/
Testing (updated)
-------
make check on
* Mac OS 10.13.4
* various linux distros
Thanks,
Alexander Rukletsov
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/#review203860
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67320']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67320
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67320/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (107 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (997 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (785 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (809 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (718 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (741 ms total)
[----------] Global test environment tear-down
[==========] 982 tests from 95 test cases ran. (447377 ms total)
[ PASSED ] 981 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67320/logs/mesos-tests-stderr.log):
```
I0525 11:32:31.528352 15596 master.cpp:10850] Updating the state of task ae699a34-f238-4f65-8e6a-2604532015ed of framework f400ddc5-9a0b-432d-8ac4-a8b347593fbb-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0525 11:32:31.528352 13136 slave.cpp:3935] Shutting down framework f400ddc5-9a0b-432d-8ac4-a8b347593fbb-0000
I0525 11:32:31.528352 13136 slave.cpp:6656] Shutting down executor 'ae699a34-f238-4f65-8e6a-2604532015ed' of framework f400ddc5-9a0b-432d-8ac4-a8b347593fbb-0000 at executor(1)@192.10.1.6:55706
I0525 11:32:31.530349 13136 slave.cpp:929] Agent terminating
W0525 11:32:31.530349 13136 slave.cpp:3931] Ignoring shutdown framework f400ddc5-9a0b-432d-8ac4-a8b347593fbb-0000 because it is terminating
I0525 11:32:31.530349 15596 master.cpp:10949] Removing task ae699a34-f238-4f65-8e6a-2604532015ed with resourcesI0525 11:32:31.365358 10628 exec.cpp:162] Version: 1.7.0
I0525 11:32:31.390403 11044 exec.cpp:236] Executor registered on agent f400ddc5-9a0b-432d-8ac4-a8b347593fbb-S0
I0525 11:32:31.394347 21740 executor.cpp:178] Received SUBSCRIBED event
I0525 11:32:31.398353 21740 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0525 11:32:31.398353 21740 executor.cpp:178] Received LAUNCH event
I0525 11:32:31.403327 21740 executor.cpp:665] Starting task ae699a34-f238-4f65-8e6a-2604532015ed
I0525 11:32:31.484365 21740 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0525 11:32:31.501353 21740 executor.cpp:678] Forked command at 24008
I0525 11:32:31.530349 22888 exec.cpp:445] Executor asked to shutdown
I0525 11:32:31.530349 23560 executor.cpp:178] Received SHUTDOWN event
I0525 11:32:31.530349 23560 executor.cpp:781] Shutting down
I0525 11:32:31.530349 23560 executor.cpp:894] Sending SIGTERM to process tree at pid 24 cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework f400ddc5-9a0b-432d-8ac4-a8b347593fbb-0000 on agent f400ddc5-9a0b-432d-8ac4-a8b347593fbb-S0 at slave(449)@192.10.1.6:55685 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 11:32:31.533350 15596 master.cpp:1293] Agent f400ddc5-9a0b-432d-8ac4-a8b347593fbb-S0 at slave(449)@192.10.1.6:55685 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0525 11:32:31.533350 15596 master.cpp:3303] Disconnecting agent f400ddc5-9a0b-432d-8ac4-a8b347593fbb-S0 at slave(449)@192.10.1.6:55685 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 11:32:31.534349 15596 master.cpp:3322] Deactivating agent f400ddc5-9a0b-432d-8ac4-a8b347593fbb-S0 at slave(449)@192.10.1.6:55685 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 11:32:31.534349 10476 hierarchical.cpp:344] Removed framework f400ddc5-9a0b-432d-8ac4-a8b347593fbb-0000
I0525 11:32:31.534349 10476 hierarchical.cpp:766] Agent f400ddc5-9a0b-432d-8ac4-a8b347593fbb-S0 deactivated
I0525 11:32:31.535353 23796 containerizer.cpp:2404] Destroying container 1cc248d5-7c71-4ed1-b3a1-2a16dfdb65de in RUNNING state
I0525 11:32:31.535353 23796 containerizer.cpp:3018] Transitioning the state of container 1cc248d5-7c71-4ed1-b3a1-2a16dfdb65de from RUNNING to DESTROYING
I0525 11:32:31.536366 23796 launcher.cpp:156] Asked to destroy container 1cc248d5-7c71-4ed1-b3a1-2a16dfdb65de
I0525 11:32:31.582352 13136 containerizer.cpp:2857] Container 1cc248d5-7c71-4ed1-b3a1-2a16dfdb65de has exited
I0525 11:32:31.611357 23384 master.cpp:1135] Master terminating
I0525 11:32:31.613353 22168 hierarchical.cpp:609] Removed agent f400ddc5-9a0b-432d-8ac4-a8b347593fbb-S0
I0525 11:32:32.083376 24096 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 25, 2018, 10:21 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67320/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 10:21 a.m.)
>
>
> Review request for mesos and Zhitao Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this patch subscribers to the master operator streaming API
> start receiving task health (check) updates. This allows subscribers
> to maintain more accurate view of the cluster's state, closer to
> what the traditional `state.json` endpoint offers.
>
>
> Diffs
> -----
>
> src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
> src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
>
>
> Diff: https://reviews.apache.org/r/67320/diff/1/
>
>
> Testing
> -------
>
> make check on
> * Mac OS 10.13.4
> * [pending] various linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 67320: Sent task (health) check updates over the
operator streaming API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67320/
-----------------------------------------------------------
(Updated May 25, 2018, 10:21 a.m.)
Review request for mesos and Zhitao Li.
Repository: mesos
Description
-------
With this patch subscribers to the master operator streaming API
start receiving task health (check) updates. This allows subscribers
to maintain more accurate view of the cluster's state, closer to
what the traditional `state.json` endpoint offers.
Diffs
-----
src/master/master.cpp 41862db9900acde85a62d2fea85459691c68556e
src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328
Diff: https://reviews.apache.org/r/67320/diff/1/
Testing (updated)
-------
make check on
* Mac OS 10.13.4
* [pending] various linux distros
Thanks,
Alexander Rukletsov