[GitHub] [incubator-pinot] jamesyfshao commented on a change in pull request #4392: Allow customized metrics prefix in pinot controller/broker/server

[GitBox <gi...@apache.org>]

jamesyfshao commented on a change in pull request #4392: Allow customized metrics prefix in pinot controller/broker/server
URL: https://github.com/apache/incubator-pinot/pull/4392#discussion_r303109696
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerMetrics.java
 ##########
 @@ -25,8 +25,18 @@
  * Metrics for the controller.
  */
 public class ControllerMetrics extends AbstractMetrics<AbstractMetrics.QueryPhase, ControllerMeter, ControllerGauge, ControllerTimer> {
+
+  // FYI this is incorrect as it generate metrics named without a dot after pinot.controller part,
+  // but we keep this default for backward compatibility in case someone relies on this format
+  // see Servermetrics or BrokerMetrics class for correct prefix should be use
+  public static final String METRICS_PREFIX_DEFAULT = "pinot.controller";
 
 Review comment:
   see the comment, it is mostly for backward compatible as the old prefix don't have the-dot

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org