You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/23 08:42:06 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
weizhouapache opened a new pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503
### Description
The default value of network.gc.wait and network.gc.interval are both 600 (seconds).
in test_vpc_redundant.py, it waits 1 hour which is unnecessary.
I have run it 10 times when I tested #4224, no isues.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-925641236
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-925614912
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-926353846
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-925640732
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-926096038
<b>Trillian test result (tid-2182)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35434 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5503-t2182-kvm-centos7.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.62 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-925629560
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-926662692
<b>Trillian test result (tid-2196)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31077 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5503-t2196-kvm-centos7.zip
Smoke tests completed. 87 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-926353661
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#discussion_r715419362
##########
File path: test/integration/smoke/test_vpc_redundant.py
##########
@@ -604,13 +604,13 @@ def test_04_rvpc_network_garbage_collector_nics(self):
self.logger.debug("network.gc.wait is ==> %s" % gc_wait)
self.logger.debug("network.gc.interval is ==> %s" % gc_interval)
- total_sleep = 120
+ total_sleep = 360
Review comment:
@rhtyd
gc_wait and gc_interval are both 600 (seconds) by default.
so the total_sleep time was (600+600) * 3 = 3600 seconds (1 hour), now it is 21 mins.
if gc_wait or gc_interval is not found in global setting, then 120 *3 seconds = 360 seconds (6 mins), it is same to it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#discussion_r715408607
##########
File path: test/integration/smoke/test_vpc_redundant.py
##########
@@ -604,13 +604,13 @@ def test_04_rvpc_network_garbage_collector_nics(self):
self.logger.debug("network.gc.wait is ==> %s" % gc_wait)
self.logger.debug("network.gc.interval is ==> %s" % gc_interval)
- total_sleep = 120
+ total_sleep = 360
Review comment:
is that 3 hrs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-926149640
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-925615326
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-926149931
<b>Trillian Build Failed (tid-2186)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5503: test_vpc_redundant.py: reduce sleep time from 1 hour to 21 mins
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5503:
URL: https://github.com/apache/cloudstack/pull/5503#issuecomment-926148214
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org