You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2024/07/31 19:14:31 UTC
(superset) branch master updated: feat: adding AntdThemeProvider to storybook config (#29795)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new da46ad4013 feat: adding AntdThemeProvider to storybook config (#29795)
da46ad4013 is described below
commit da46ad4013695c42d7a279ce677f67fdd05c3efe
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Wed Jul 31 13:14:26 2024 -0600
feat: adding AntdThemeProvider to storybook config (#29795)
---
superset-frontend/.storybook/preview.jsx | 5 +++--
.../src/components/Badge/Badge.stories.tsx | 25 ++++++++--------------
.../src/components/Card/Card.stories.tsx | 7 +-----
.../components/ProgressBar/ProgressBar.stories.tsx | 13 +++--------
.../src/components/Tags/Tag.stories.tsx | 7 +-----
.../src/components/Tags/TagsList.stories.tsx | 5 +----
6 files changed, 18 insertions(+), 44 deletions(-)
diff --git a/superset-frontend/.storybook/preview.jsx b/superset-frontend/.storybook/preview.jsx
index 42784d2d18..ef27f3591e 100644
--- a/superset-frontend/.storybook/preview.jsx
+++ b/superset-frontend/.storybook/preview.jsx
@@ -18,6 +18,7 @@
*/
import { withJsx } from '@mihkeleidast/storybook-addon-source';
import { supersetTheme, ThemeProvider } from '@superset-ui/core';
+import { AntdThemeProvider } from '../src/components/AntdThemeProvider';
import { combineReducers, createStore, applyMiddleware, compose } from 'redux';
import thunk from 'redux-thunk';
import { Provider } from 'react-redux';
@@ -35,10 +36,10 @@ const store = createStore(
const themeDecorator = Story => (
<ThemeProvider theme={supersetTheme}>
- <>
+ <AntdThemeProvider>
<GlobalStyles />
<Story />
- </>
+ </AntdThemeProvider>
</ThemeProvider>
);
diff --git a/superset-frontend/src/components/Badge/Badge.stories.tsx b/superset-frontend/src/components/Badge/Badge.stories.tsx
index 781f6220c7..505c51ab38 100644
--- a/superset-frontend/src/components/Badge/Badge.stories.tsx
+++ b/superset-frontend/src/components/Badge/Badge.stories.tsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { AntdThemeProvider } from 'src/components/AntdThemeProvider';
import Badge, { BadgeProps } from '.';
export default {
@@ -59,11 +58,7 @@ const SIZES = {
defaultValue: undefined,
};
-export const InteractiveBadge = (args: BadgeProps) => (
- <AntdThemeProvider>
- <Badge {...args} />
- </AntdThemeProvider>
-);
+export const InteractiveBadge = (args: BadgeProps) => <Badge {...args} />;
InteractiveBadge.args = {
count: undefined,
@@ -120,16 +115,14 @@ export const BadgeGallery = () => (
{SIZES.options.map(size => (
<div key={size} style={{ marginBottom: 40 }}>
<h4>{size}</h4>
- <AntdThemeProvider>
- {COLORS.options.map(color => (
- <Badge
- count={9}
- size={size}
- key={`${color}_${size}`}
- style={{ marginRight: '15px' }}
- />
- ))}
- </AntdThemeProvider>
+ {COLORS.options.map(color => (
+ <Badge
+ count={9}
+ size={size}
+ key={`${color}_${size}`}
+ style={{ marginRight: '15px' }}
+ />
+ ))}
</div>
))}
</>
diff --git a/superset-frontend/src/components/Card/Card.stories.tsx b/superset-frontend/src/components/Card/Card.stories.tsx
index 83ad2369ed..dad9138262 100644
--- a/superset-frontend/src/components/Card/Card.stories.tsx
+++ b/superset-frontend/src/components/Card/Card.stories.tsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { AntdThemeProvider } from 'src/components/AntdThemeProvider';
import Card, { CardProps } from '.';
export default {
@@ -24,11 +23,7 @@ export default {
component: Card,
};
-export const InteractiveCard = (args: CardProps) => (
- <AntdThemeProvider>
- <Card {...args} />
- </AntdThemeProvider>
-);
+export const InteractiveCard = (args: CardProps) => <Card {...args} />;
InteractiveCard.args = {
padded: true,
diff --git a/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx b/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx
index 62ad8ae203..37f6535754 100644
--- a/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx
+++ b/superset-frontend/src/components/ProgressBar/ProgressBar.stories.tsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { AntdThemeProvider } from 'src/components/AntdThemeProvider';
import ProgressBar, { ProgressBarProps } from '.';
export default {
@@ -25,21 +24,15 @@ export default {
};
export const InteractiveProgressBar = (args: ProgressBarProps) => (
- <AntdThemeProvider>
- <ProgressBar {...args} type="line" />
- </AntdThemeProvider>
+ <ProgressBar {...args} type="line" />
);
export const InteractiveProgressCircle = (args: ProgressBarProps) => (
- <AntdThemeProvider>
- <ProgressBar {...args} type="circle" />
- </AntdThemeProvider>
+ <ProgressBar {...args} type="circle" />
);
export const InteractiveProgressDashboard = (args: ProgressBarProps) => (
- <AntdThemeProvider>
- <ProgressBar {...args} type="dashboard" />
- </AntdThemeProvider>
+ <ProgressBar {...args} type="dashboard" />
);
const commonArgs = {
diff --git a/superset-frontend/src/components/Tags/Tag.stories.tsx b/superset-frontend/src/components/Tags/Tag.stories.tsx
index bcd29cd131..b6d82bff93 100644
--- a/superset-frontend/src/components/Tags/Tag.stories.tsx
+++ b/superset-frontend/src/components/Tags/Tag.stories.tsx
@@ -16,7 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { AntdThemeProvider } from 'src/components/AntdThemeProvider';
import TagType from 'src/types/TagType';
import { Tag } from '.';
@@ -24,11 +23,7 @@ export default {
title: 'Tags',
component: Tag,
};
-export const InteractiveTag = (args: TagType) => (
- <AntdThemeProvider>
- <Tag {...args} />
- </AntdThemeProvider>
-);
+export const InteractiveTag = (args: TagType) => <Tag {...args} />;
InteractiveTag.args = {
editable: false,
diff --git a/superset-frontend/src/components/Tags/TagsList.stories.tsx b/superset-frontend/src/components/Tags/TagsList.stories.tsx
index 3c9a19ef38..622ab155e7 100644
--- a/superset-frontend/src/components/Tags/TagsList.stories.tsx
+++ b/superset-frontend/src/components/Tags/TagsList.stories.tsx
@@ -17,7 +17,6 @@
* under the License.
*/
import TagType from 'src/types/TagType';
-import { AntdThemeProvider } from 'src/components/AntdThemeProvider';
import { TagsList } from '.';
import { TagsListProps } from './TagsList';
@@ -31,9 +30,7 @@ export const InteractiveTagsList = ({
editable,
maxTags,
}: TagsListProps) => (
- <AntdThemeProvider>
- <TagsList tags={tags} editable={editable} maxTags={maxTags} />
- </AntdThemeProvider>
+ <TagsList tags={tags} editable={editable} maxTags={maxTags} />
);
const tags: TagType[] = [