You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@climate.apache.org by prateekiiest <gi...@git.apache.org> on 2018/06/23 16:57:07 UTC

[GitHub] climate pull request #513: [CLIMATE - 957] Include Absolute Biasing under Me...

GitHub user prateekiiest opened a pull request:

    https://github.com/apache/climate/pull/513

    [CLIMATE - 957] Include Absolute Biasing under Metrics

    Fixes issue https://issues.apache.org/jira/browse/CLIMATE-957

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prateekiiest/climate patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #513
    
----
commit 4fd7d4916f12757434fe4494940aac064ca24852
Author: Prateek Chanda <pr...@...>
Date:   2018-06-23T16:55:12Z

    include absolute bias

----


---

[GitHub] climate pull request #513: [CLIMATE - 957] Include Absolute Biasing under Me...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/climate/pull/513


---

[GitHub] climate issue #513: [CLIMATE - 957] Include Absolute Biasing under Metrics

Posted by prateekiiest <gi...@git.apache.org>.

Github user prateekiiest commented on the issue:

    https://github.com/apache/climate/pull/513
  
    @lewismc could you please make a review. I will add further changes if required


---

[GitHub] climate issue #513: [CLIMATE - 957] Include Absolute Biasing under Metrics

Posted by prateekiiest <gi...@git.apache.org>.

Github user prateekiiest commented on the issue:

    https://github.com/apache/climate/pull/513
  
    sure @lewismc , I will add a test soon


---

[GitHub] climate issue #513: [CLIMATE - 957] Include Absolute Biasing under Metrics

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/climate/pull/513
  
    +1, @prateekiiest thank you


---

[GitHub] climate issue #513: [CLIMATE - 957] Include Absolute Biasing under Metrics

Posted by prateekiiest <gi...@git.apache.org>.

Github user prateekiiest commented on the issue:

    https://github.com/apache/climate/pull/513
  
    @lewismc could you have a look at it?


---

[GitHub] climate issue #513: [CLIMATE - 957] Include Absolute Biasing under Metrics

Posted by prateekiiest <gi...@git.apache.org>.

Github user prateekiiest commented on the issue:

    https://github.com/apache/climate/pull/513
  
    Thanks @lewismc


---

[GitHub] climate issue #513: [CLIMATE - 957] Include Absolute Biasing under Metrics

Posted by prateekiiest <gi...@git.apache.org>.

Github user prateekiiest commented on the issue:

    https://github.com/apache/climate/pull/513
  
    Added test for this


---

[GitHub] climate issue #513: [CLIMATE - 957] Include Absolute Biasing under Metrics

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/climate/pull/513
  
    @prateekiiest can you please provide a Unit test?


---