You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/03/11 22:25:18 UTC
Review Request 44726: Limit the scope of hot-reload resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44726/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
Description
-------
This limits the hot-reload resources to those found under
dist/resources/main/scheduler (all the UI resources), in order to
prevent confusion when rebuilding the scheduler for use in the vagrant
vm with non-ui resource changes (say to the db schema.sql).
docs/developing-aurora-scheduler.md | 8 ++++----
examples/vagrant/aurorabuild.sh | 11 ++++++++++-
2 files changed, 14 insertions(+), 5 deletions(-)
Diffs
-----
docs/developing-aurora-scheduler.md a7a929e0c1bc58070603d2ff7736a4e264f9b0ec
examples/vagrant/aurorabuild.sh 92066e8461246ca76c00b273960dec85a5e94338
Diff: https://reviews.apache.org/r/44726/diff/
Testing
-------
I manually tested resilience by deleting `/vagrant/dist/.hot_resources`
and `/vagrant/dist/.hot_resources/scheduler` and running
`aurorabuild scheduler` after each. I also double checked the
head-of-the `CLASSPATH` trick by checking the classpath:
`-classpath /vagrant/dist/.hot_resources:/home/...` and live editing
`dist/resources/main/scheduler/assets/index.html` from outside the vm
and reloading that root links page.
Thanks,
John Sirois
Re: Review Request 44726: Limit the scope of hot-reload resources.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44726/#review123218
-----------------------------------------------------------
Ship it!
Master (7fc4bff) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 11, 2016, 9:25 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44726/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 9:25 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This limits the hot-reload resources to those found under
> dist/resources/main/scheduler (all the UI resources), in order to
> prevent confusion when rebuilding the scheduler for use in the vagrant
> vm with non-ui resource changes (say to the db schema.sql).
>
> docs/developing-aurora-scheduler.md | 8 ++++----
> examples/vagrant/aurorabuild.sh | 11 ++++++++++-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/developing-aurora-scheduler.md a7a929e0c1bc58070603d2ff7736a4e264f9b0ec
> examples/vagrant/aurorabuild.sh 92066e8461246ca76c00b273960dec85a5e94338
>
> Diff: https://reviews.apache.org/r/44726/diff/
>
>
> Testing
> -------
>
> I manually tested resilience by deleting `/vagrant/dist/.hot_resources`
> and `/vagrant/dist/.hot_resources/scheduler` and running
> `aurorabuild scheduler` after each. I also double checked the
> head-of-the `CLASSPATH` trick by checking the classpath:
> `-classpath /vagrant/dist/.hot_resources:/home/...` and live editing
> `dist/resources/main/scheduler/assets/index.html` from outside the vm
> and reloading that root links page.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 44726: Limit the scope of hot-reload resources.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44726/#review123221
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 11, 2016, 1:25 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44726/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 1:25 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This limits the hot-reload resources to those found under
> dist/resources/main/scheduler (all the UI resources), in order to
> prevent confusion when rebuilding the scheduler for use in the vagrant
> vm with non-ui resource changes (say to the db schema.sql).
>
> docs/developing-aurora-scheduler.md | 8 ++++----
> examples/vagrant/aurorabuild.sh | 11 ++++++++++-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/developing-aurora-scheduler.md a7a929e0c1bc58070603d2ff7736a4e264f9b0ec
> examples/vagrant/aurorabuild.sh 92066e8461246ca76c00b273960dec85a5e94338
>
> Diff: https://reviews.apache.org/r/44726/diff/
>
>
> Testing
> -------
>
> I manually tested resilience by deleting `/vagrant/dist/.hot_resources`
> and `/vagrant/dist/.hot_resources/scheduler` and running
> `aurorabuild scheduler` after each. I also double checked the
> head-of-the `CLASSPATH` trick by checking the classpath:
> `-classpath /vagrant/dist/.hot_resources:/home/...` and live editing
> `dist/resources/main/scheduler/assets/index.html` from outside the vm
> and reloading that root links page.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 44726: Limit the scope of hot-reload resources.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44726/#review123209
-----------------------------------------------------------
A render of the changed docs is here: https://github.com/jsirois/aurora/blob/jsirois/ui/hot_reload_scope_limiting/docs/developing-aurora-scheduler.md#faster-iteration-in-vagrant
- John Sirois
On March 11, 2016, 2:25 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44726/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 2:25 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This limits the hot-reload resources to those found under
> dist/resources/main/scheduler (all the UI resources), in order to
> prevent confusion when rebuilding the scheduler for use in the vagrant
> vm with non-ui resource changes (say to the db schema.sql).
>
> docs/developing-aurora-scheduler.md | 8 ++++----
> examples/vagrant/aurorabuild.sh | 11 ++++++++++-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/developing-aurora-scheduler.md a7a929e0c1bc58070603d2ff7736a4e264f9b0ec
> examples/vagrant/aurorabuild.sh 92066e8461246ca76c00b273960dec85a5e94338
>
> Diff: https://reviews.apache.org/r/44726/diff/
>
>
> Testing
> -------
>
> I manually tested resilience by deleting `/vagrant/dist/.hot_resources`
> and `/vagrant/dist/.hot_resources/scheduler` and running
> `aurorabuild scheduler` after each. I also double checked the
> head-of-the `CLASSPATH` trick by checking the classpath:
> `-classpath /vagrant/dist/.hot_resources:/home/...` and live editing
> `dist/resources/main/scheduler/assets/index.html` from outside the vm
> and reloading that root links page.
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 44726: Limit the scope of hot-reload resources.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44726/#review123217
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On March 11, 2016, 9:25 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44726/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 9:25 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This limits the hot-reload resources to those found under
> dist/resources/main/scheduler (all the UI resources), in order to
> prevent confusion when rebuilding the scheduler for use in the vagrant
> vm with non-ui resource changes (say to the db schema.sql).
>
> docs/developing-aurora-scheduler.md | 8 ++++----
> examples/vagrant/aurorabuild.sh | 11 ++++++++++-
> 2 files changed, 14 insertions(+), 5 deletions(-)
>
>
> Diffs
> -----
>
> docs/developing-aurora-scheduler.md a7a929e0c1bc58070603d2ff7736a4e264f9b0ec
> examples/vagrant/aurorabuild.sh 92066e8461246ca76c00b273960dec85a5e94338
>
> Diff: https://reviews.apache.org/r/44726/diff/
>
>
> Testing
> -------
>
> I manually tested resilience by deleting `/vagrant/dist/.hot_resources`
> and `/vagrant/dist/.hot_resources/scheduler` and running
> `aurorabuild scheduler` after each. I also double checked the
> head-of-the `CLASSPATH` trick by checking the classpath:
> `-classpath /vagrant/dist/.hot_resources:/home/...` and live editing
> `dist/resources/main/scheduler/assets/index.html` from outside the vm
> and reloading that root links page.
>
>
> Thanks,
>
> John Sirois
>
>