[GitHub] [spark] cloud-fan commented on pull request #35494: [SPARK-38196][SQL] Reactor framework so as JDBC dialect could compile expression by self way

[GitBox <gi...@apache.org>]

cloud-fan commented on pull request #35494:
URL: https://github.com/apache/spark/pull/35494#issuecomment-1044616306


   Instead of adding one v2 expression class for each catalyst expression, I agree it's much simpler to have a general v2 expression class that is a tree structure.
   
   However, we must clearly document the name for each supported v2 expression, similar to `GeneralAggregateFunc`.
   
   For the naming, maybe `GeneralScalarExpression` to differentiate from `GeneralAggregateFunc`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org