You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/18 03:39:04 UTC
[GitHub] [spark] Yikf opened a new pull request #35564: [SPARK-38247][SQL] Unify the output of df.explain and "explain " if plan is command
Yikf opened a new pull request #35564:
URL: https://github.com/apache/spark/pull/35564
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This pr aims to unify the out of df.explain and "explain" sql if plan is a command
unify the out of df.explain and "explain" sql if plan is a command
Make the output of explain unambiguous if plan is a command
Lets say have a query like "show tables", we want to explain it -> sql("show tables").explain("extended")
**Before this pr:**
```
== Parsed Logical Plan ==
'ShowTables [namespace#62, tableName#63, isTemporary#64]
+- 'UnresolvedNamespace
== Analyzed Logical Plan ==
namespace: string, tableName: string, isTemporary: boolean
ShowTablesCommand default, [namespace#62, tableName#63, isTemporary#64], false
== Optimized Logical Plan ==
CommandResult [namespace#62, tableName#63, isTemporary#64], Execute ShowTablesCommand, [[default,lt,false], [default,people,false], [default,person,false], [default,rt,false], [default,t,false], [default,t1,false], [default,t10086,false], [default,txtsource,false]]
+- ShowTablesCommand default, [namespace#62, tableName#63, isTemporary#64], false
== Physical Plan ==
CommandResult [namespace#62, tableName#63, isTemporary#64]
+- Execute ShowTablesCommand
+- ShowTablesCommand default, [namespace#62, tableName#63, isTemporary#64], false
```
**After this pr:**
```
== Parsed Logical Plan ==
'ShowTables [namespace#0, tableName#1, isTemporary#2]
+- 'UnresolvedNamespace
== Analyzed Logical Plan ==
namespace: string, tableName: string, isTemporary: boolean
ShowTables [namespace#0, tableName#1, isTemporary#2]
+- ResolvedNamespace V2SessionCatalog(spark_catalog), [default]
== Optimized Logical Plan ==
ShowTables [namespace#0, tableName#1, isTemporary#2]
+- ResolvedNamespace V2SessionCatalog(spark_catalog), [default]
== Physical Plan ==
ShowTables [namespace#0, tableName#1, isTemporary#2], V2SessionCatalog(spark_catalog), [default]
```
### Why are the changes needed?
Make the output of `df.explain` unambiguous
### Does this PR introduce _any_ user-facing change?
Yes, improve the out of `df.explain`
### How was this patch tested?
add test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on pull request #35564: [SPARK-38247][SQL] Unify the output of df.explain and "explain " if plan is command
Posted by GitBox <gi...@apache.org>.
Yikf commented on pull request #35564:
URL: https://github.com/apache/spark/pull/35564#issuecomment-1043972728
This is invalid, i intend to close it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf edited a comment on pull request #35564: [SPARK-38247][SQL] Unify the output of df.explain and "explain " if plan is command
Posted by GitBox <gi...@apache.org>.
Yikf edited a comment on pull request #35564:
URL: https://github.com/apache/spark/pull/35564#issuecomment-1043830166
Could you please take a look, thanks @cloud-fan @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf commented on pull request #35564: [SPARK-38247][SQL] Unify the output of df.explain and "explain " if plan is command
Posted by GitBox <gi...@apache.org>.
Yikf commented on pull request #35564:
URL: https://github.com/apache/spark/pull/35564#issuecomment-1043830166
Could you please take a look @cloud-fan @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikf closed pull request #35564: [SPARK-38247][SQL] Unify the output of df.explain and "explain " if plan is command
Posted by GitBox <gi...@apache.org>.
Yikf closed pull request #35564:
URL: https://github.com/apache/spark/pull/35564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org