You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Matej Knopp (JIRA)" <ji...@apache.org> on 2007/12/20 16:56:43 UTC

[jira] Commented: (WICKET-1149) LocalizedImageResource not formatting parameters properly when using ResourceReference

    [ https://issues.apache.org/jira/browse/WICKET-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553702 ] 

Matej Knopp commented on WICKET-1149:
-------------------------------------

The reason it because it is rendering html output. And in html you can't just put & anywhere you want. You have to escape it properly.

So urlFor returns non-escaped url, e.g. ?xyz&a=b&c=d  but in the html we have to escape the &, i.e. output ?xyz&amp;a=b&amp;c=d 
because otherwise the document is not well formed. 

> LocalizedImageResource not formatting parameters properly when using ResourceReference
> --------------------------------------------------------------------------------------
>
>                 Key: WICKET-1149
>                 URL: https://issues.apache.org/jira/browse/WICKET-1149
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta4, 1.3.0-rc1
>            Reporter: Doug Leeper
>            Assignee: Matej Knopp
>            Priority: Critical
>             Fix For: 1.3.0-rc3
>
>
> When using a ResourceReference, the resultant URL generated is not formatted properly when using more than one parameter.  
> For example:
> Correct URL:
> http://localhost:8081/homeIQ/app/resources/homeiq.wicket.HomeIQApplication/modelPicture?thumbnail=true&maxHeight=100&maxWidth=100&id=1
> Incorrect URL: (generated by LocalizedResourceReference)
> http://localhost:8081/homeIQ/app/resources/homeiq.wicket.HomeIQApplication/modelPicture?thumbnail=true&amp;maxHeight=100&amp;maxWidth=100&amp;id=1
> As can be seen, the & has been replaced with &amp;.  This is the result of the following code:
> 		tag.put("src", RequestCycle.get().getOriginalResponse().encodeURL(
> 			Strings.replaceAll(url, "&", "&amp;")));
> It should be:
> 		tag.put("src", RequestCycle.get().getOriginalResponse().encodeURL(url);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.