You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/03 09:25:06 UTC
[GitHub] [dolphinscheduler-website] Tianqi-Dotes opened a new pull request #711: fix-headlines
Tianqi-Dotes opened a new pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711
According to the rules below:
1. Use Headline-style capitalization in all headlines.
2. Use document name as lvl.1(#) heading.
3. Use ascend count of # to the sub-headings.
4. Use a blank line under and below each heading.
5. Delete number counters in the sub-headings. (like '1.1.x')
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711#issuecomment-1058732721
@Tianqi-Dotes there is one more thing I want to say. For now, you change version 2.0.3 docs. But we plan to release 2.0.5 docs in #706 . And the next release version is 3.0.0 from dev. Do you think we should directly change dev doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711#discussion_r818485175
##########
File path: docs/en-us/2.0.3/user_doc/architecture/configuration.md
##########
@@ -70,7 +70,8 @@ serial number| service classification| config file|
12|services log config files|API-service log config : logback-api.xml <br /> master-service log config : logback-master.xml <br /> worker-service log config : logback-worker.xml <br /> alert-service log config : logback-alert.xml
-## 1.dolphinscheduler-daemon.sh [startup/shutdown DS application]
+### 1.dolphinscheduler-daemon.sh [startup/shutdown DS application]
Review comment:
should we also remove `1.`
##########
File path: docs/en-us/2.0.3/user_doc/architecture/configuration.md
##########
@@ -47,12 +50,9 @@ Currently, all the configuration files are under [conf ] directory. Please check
├─ui front-end web resources directory
├─lib DS .jar dependencies directory
├─install.sh auto-setup DS services script
-
-
```
-
-# Configurations in Details
+## Configurations in Details
Review comment:
How about `in`
##########
File path: docs/en-us/2.0.3/user_doc/architecture/design.md
##########
@@ -50,7 +50,7 @@ scheduling system
WorkerServer also adopts a distributed centerless design concept, supports custom task plug-ins, and is mainly responsible for task execution and log services.
When the WorkerServer service starts, it registers a temporary node with Zookeeper and maintains a heartbeat.
-##### The service mainly includes
+ #### The Service Mainly Includes
Review comment:
```suggestion
#### The Service Mainly Includes
```
##########
File path: docs/en-us/2.0.3/user_doc/guide/installation/docker.md
##########
@@ -5,17 +5,17 @@
- [Docker](https://docs.docker.com/engine/install/) 1.13.1+
- [Docker Compose](https://docs.docker.com/compose/) 1.11.0+
-## How to use this Docker image
+## How to use this Docker Image
Review comment:
Should we use `How To Use This Docker Image`
##########
File path: docs/en-us/2.0.3/user_doc/architecture/configuration.md
##########
@@ -70,7 +70,8 @@ serial number| service classification| config file|
12|services log config files|API-service log config : logback-api.xml <br /> master-service log config : logback-master.xml <br /> worker-service log config : logback-worker.xml <br /> alert-service log config : logback-alert.xml
-## 1.dolphinscheduler-daemon.sh [startup/shutdown DS application]
+### 1.dolphinscheduler-daemon.sh [startup/shutdown DS application]
Review comment:
Also the below number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on a change in pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on a change in pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711#discussion_r818556416
##########
File path: docs/en-us/2.0.3/user_doc/architecture/configuration.md
##########
@@ -70,7 +70,8 @@ serial number| service classification| config file|
12|services log config files|API-service log config : logback-api.xml <br /> master-service log config : logback-master.xml <br /> worker-service log config : logback-worker.xml <br /> alert-service log config : logback-alert.xml
-## 1.dolphinscheduler-daemon.sh [startup/shutdown DS application]
+### 1.dolphinscheduler-daemon.sh [startup/shutdown DS application]
Review comment:
done remove all the numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711#issuecomment-1057870798
Good job. but should we add some lint to do it, instead of check by a human? I find our we have some lint about markdown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711#issuecomment-1057872497
I did some research before, which you could see in https://github.com/apache/dolphinscheduler/issues/6535 , section `CI`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] Tianqi-Dotes commented on a change in pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
Tianqi-Dotes commented on a change in pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711#discussion_r818556075
##########
File path: docs/en-us/2.0.3/user_doc/guide/installation/docker.md
##########
@@ -5,17 +5,17 @@
- [Docker](https://docs.docker.com/engine/install/) 1.13.1+
- [Docker Compose](https://docs.docker.com/compose/) 1.11.0+
-## How to use this Docker image
+## How to use this Docker Image
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #711: fix-headlines
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #711:
URL: https://github.com/apache/dolphinscheduler-website/pull/711#issuecomment-1059011216
CI still running, we can not merge untill it pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org