[GitHub] [druid] gianm commented on a diff in pull request #14196: SortMergeJoinFrameProcessor: Fix two bugs with buffering.

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on code in PR #14196:
URL: https://github.com/apache/druid/pull/14196#discussion_r1242946240


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/common/SortMergeJoinFrameProcessor.java:
##########
@@ -273,12 +275,14 @@ public ReturnOrAwait<Long> runIncrementally(IntSet readableInputs) throws IOExce
 
         tracker.advance();
 
-        // On next iteration (when we're sure to have data), update mark if the key changed.
+        // On next iteration (when we're sure to have data), check if we've moved on to a new key.
         onNextIteration(() -> {
           if (!tracker.isCurrentSameKeyAsMark()) {

Review Comment:
   Looks like a good idea. The real code has to be a little more complex, but I did add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org