You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/29 07:51:33 UTC

[GitHub] [flink] gaoyunhaii commented on pull request #13595: [FLINK-19582][network] Introduce sort-merge based blocking shuffle to Flink

gaoyunhaii commented on pull request #13595:
URL: https://github.com/apache/flink/pull/13595#issuecomment-718444548


   Very thanks for @wsry  opening the PR and @StephanEwen @zhijiangW for the reviewing! The PR also looks good to me in general from my side and thus +1 for merging. A small issue is that if available, I still tend to that we add some tests covering the case some subpartitions are empty in the SortBuffer or in one region, as @zhijiangW pointed out before, since we have some logic related to skip the empty sub-partitions. Of course if not available we may also add the tests in the separate PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org