You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/05/18 22:25:34 UTC

[GitHub] incubator-zeppelin pull request: Fix a few image not rendering

GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/899

    Fix a few image not rendering

    ### What is this PR for?
    There was a recent PR made by @doanduyhai that was changing some images URL to include `../assets`. However, I found a few more cases in the deployed website.
    It is actually a bit hard to understand why this happens in some cases only, maybe it could be better to replace all `/assets` to `../assets`, however this PR is only fixing the current issues.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### How should this be tested?
    You can build the doc and run it locally
    
    ### Screenshots (if appropriate)
    
    <img width="688" alt="screen shot 2016-05-18 at 3 20 53 pm" src="https://cloud.githubusercontent.com/assets/710411/15376817/45648b78-1d0c-11e6-82cb-4ba106e01043.png">
    <img width="521" alt="screen shot 2016-05-18 at 3 21 09 pm" src="https://cloud.githubusercontent.com/assets/710411/15376819/493ff976-1d0c-11e6-9960-cbd568f5d0ec.png">
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin fix/docsImagesLink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/899.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #899
    
----
commit c7333d7fd1ee12feda7cc2b57281ef1db864bb3a
Author: Damien CORNEAU <co...@gmail.com>
Date:   2016-05-18T22:19:12Z

    Fix a few image not rendering

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix a few image not rendering

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/899


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix a few image not rendering

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/899#issuecomment-221436945
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---