You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/03 03:17:24 UTC

[GitHub] [fineract] ptuomola opened a new pull request #1144: FINERACT-1016: Removing partial fix to 1st month issue

ptuomola opened a new pull request #1144:
URL: https://github.com/apache/fineract/pull/1144


   ## Description
   My previous fix to FINERACT-1016 accidentally included a partial fix to the "tests failing on 1st month" issue in addition to the rounding fix. Unfortunately that partial fix caused the tests to fail on some days. This PR removes that partial fix which will be resubmitted as a separate PR. 
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1144: FINERACT-1016: Removing partial fix to 1st month issue

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1144:
URL: https://github.com/apache/fineract/pull/1144#issuecomment-653450950


   - Your PRs are never Trouble, only Pure Joy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger merged pull request #1144: FINERACT-1016: Removing partial fix to 1st month issue

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1144:
URL: https://github.com/apache/fineract/pull/1144


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1144: FINERACT-1016: Removing partial fix to 1st month issue

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1144:
URL: https://github.com/apache/fineract/pull/1144#issuecomment-653333219


   @vorburger Sorry to trouble you before your holiday, but here's a one-line fix to get the builds passing again. I had started working on the "tests fail on 1st month issue" and accidentally included one line of that solution in the fix I submitted yesterday. This just removes that one line. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org