You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by en...@apache.org on 2014/03/27 01:54:15 UTC
svn commit: r1582142 - in
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase: mapred/
mapreduce/ master/ util/
Author: enis
Date: Thu Mar 27 00:54:15 2014
New Revision: 1582142
URL: http://svn.apache.org/r1582142
Log:
HBASE-10842 Some loggers not declared static final (Richard Ding)
Modified:
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/HRegionPartitioner.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormat.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormatBase.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/OfflineCallback.java
hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSizeCalculator.java
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/HRegionPartitioner.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/HRegionPartitioner.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/HRegionPartitioner.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/HRegionPartitioner.java Thu Mar 27 00:54:15 2014
@@ -45,7 +45,7 @@ import org.apache.hadoop.mapred.Partitio
@InterfaceStability.Stable
public class HRegionPartitioner<K2,V2>
implements Partitioner<ImmutableBytesWritable, V2> {
- private final Log LOG = LogFactory.getLog(TableInputFormat.class);
+ private static final Log LOG = LogFactory.getLog(HRegionPartitioner.class);
private HTable table;
private byte[][] startKeys;
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormat.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormat.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormat.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormat.java Thu Mar 27 00:54:15 2014
@@ -41,7 +41,7 @@ import org.apache.hadoop.util.StringUtil
@InterfaceStability.Stable
public class TableInputFormat extends TableInputFormatBase implements
JobConfigurable {
- private final Log LOG = LogFactory.getLog(TableInputFormat.class);
+ private static final Log LOG = LogFactory.getLog(TableInputFormat.class);
/**
* space delimited list of columns
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormatBase.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormatBase.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormatBase.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormatBase.java Thu Mar 27 00:54:15 2014
@@ -70,7 +70,7 @@ import org.apache.hadoop.mapred.Reporter
@InterfaceStability.Stable
public abstract class TableInputFormatBase
implements InputFormat<ImmutableBytesWritable, Result> {
- final Log LOG = LogFactory.getLog(TableInputFormatBase.class);
+ private static final Log LOG = LogFactory.getLog(TableInputFormatBase.class);
private byte [][] inputColumns;
private HTable table;
private TableRecordReader tableRecordReader;
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableOutputFormat.java Thu Mar 27 00:54:15 2014
@@ -48,7 +48,7 @@ FileOutputFormat<ImmutableBytesWritable,
/** JobConf parameter that specifies the output table */
public static final String OUTPUT_TABLE = "hbase.mapred.outputtable";
- private final Log LOG = LogFactory.getLog(TableOutputFormat.class);
+ private static final Log LOG = LogFactory.getLog(TableOutputFormat.class);
/**
* Convert Reduce output (key, value) to (HStoreKey, KeyedDataArrayWritable)
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HRegionPartitioner.java Thu Mar 27 00:54:15 2014
@@ -51,7 +51,7 @@ public class HRegionPartitioner<KEY, VAL
extends Partitioner<ImmutableBytesWritable, VALUE>
implements Configurable {
- private final Log LOG = LogFactory.getLog(TableInputFormat.class);
+ private static final Log LOG = LogFactory.getLog(HRegionPartitioner.class);
private Configuration conf = null;
private HTable table;
private byte[][] startKeys;
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java Thu Mar 27 00:54:15 2014
@@ -40,7 +40,7 @@ import org.apache.hadoop.util.StringUtil
public class TableInputFormat extends TableInputFormatBase
implements Configurable {
- private final Log LOG = LogFactory.getLog(TableInputFormat.class);
+ private static final Log LOG = LogFactory.getLog(TableInputFormat.class);
/** Job parameter that specifies the input table. */
public static final String INPUT_TABLE = "hbase.mapreduce.inputtable";
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java Thu Mar 27 00:54:15 2014
@@ -51,7 +51,7 @@ import org.apache.hadoop.mapreduce.TaskA
public class TableOutputFormat<KEY> extends OutputFormat<KEY, Mutation>
implements Configurable {
- private final Log LOG = LogFactory.getLog(TableOutputFormat.class);
+ private static final Log LOG = LogFactory.getLog(TableOutputFormat.class);
/** Job parameter that specifies the output table. */
public static final String OUTPUT_TABLE = "hbase.mapred.outputtable";
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/OfflineCallback.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/OfflineCallback.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/OfflineCallback.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/OfflineCallback.java Thu Mar 27 00:54:15 2014
@@ -37,7 +37,7 @@ import org.apache.zookeeper.data.Stat;
*/
@InterfaceAudience.Private
public class OfflineCallback implements StringCallback {
- private final Log LOG = LogFactory.getLog(OfflineCallback.class);
+ private static final Log LOG = LogFactory.getLog(OfflineCallback.class);
private final ExistCallback callBack;
private final ZooKeeperWatcher zkw;
private final ServerName destination;
@@ -79,7 +79,7 @@ public class OfflineCallback implements
* Used during bulk assign on startup.
*/
static class ExistCallback implements StatCallback {
- private final Log LOG = LogFactory.getLog(ExistCallback.class);
+ private static final Log LOG = LogFactory.getLog(ExistCallback.class);
private final Map<String, Integer> offlineNodesVersions;
private final AtomicInteger counter;
private ServerName destination;
Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSizeCalculator.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSizeCalculator.java?rev=1582142&r1=1582141&r2=1582142&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSizeCalculator.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSizeCalculator.java Thu Mar 27 00:54:15 2014
@@ -48,7 +48,7 @@ import java.util.TreeSet;
@InterfaceAudience.Private
public class RegionSizeCalculator {
- private final Log LOG = LogFactory.getLog(RegionSizeCalculator.class);
+ private static final Log LOG = LogFactory.getLog(RegionSizeCalculator.class);
/**
* Maps each region to its size in bytes.