You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/07/23 02:53:29 UTC
[Impala-ASF-CR] IMPALA-15208: Bump wait time for TestAsyncDDL.test get operation status for async ddl
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24625
Change subject: IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
......................................................................
IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
After the fix for IMPALA-13690, there has been occasional
flakiness where TestAsyncDDL.test_get_operation_status_for_async_ddl
is timing out waiting for the query to transition from RUNNING
to FINISHED. It currently waits 5 seconds, which is 2 seconds
for the sleep in the query plus another 3 seconds as a buffer.
These failures tend to happen on slower build types like
ASAN and code coverage. The actual execution time of the query
is not really what we are testing, so this bumps the wait time
to 12 seconds (2 for the sleep plus 10 seconds as a buffer).
Testing:
- Ran TestAsyncDDL.test_get_operation_status_for_async_ddl
locally
Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
---
M tests/metadata/test_ddl.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/24625/1
--
To view, visit http://gerrit.cloudera.org:8080/24625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Gerrit-Change-Number: 24625
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-15208: Bump wait time for TestAsyncDDL.test get operation status for async ddl
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24625 )
Change subject: IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Gerrit-Change-Number: 24625
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 16:01:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15208: Bump wait time for TestAsyncDDL.test get operation status for async ddl
Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24625 )
Change subject: IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Gerrit-Change-Number: 24625
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 15:33:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15208: Bump wait time for TestAsyncDDL.test get operation status for async ddl
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24625 )
Change subject: IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
......................................................................
IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
After the fix for IMPALA-13690, there has been occasional
flakiness where TestAsyncDDL.test_get_operation_status_for_async_ddl
is timing out waiting for the query to transition from RUNNING
to FINISHED. It currently waits 5 seconds, which is 2 seconds
for the sleep in the query plus another 3 seconds as a buffer.
These failures tend to happen on slower build types like
ASAN and code coverage. The actual execution time of the query
is not really what we are testing, so this bumps the wait time
to 12 seconds (2 for the sleep plus 10 seconds as a buffer).
Testing:
- Ran TestAsyncDDL.test_get_operation_status_for_async_ddl
locally
Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Reviewed-on: http://gerrit.cloudera.org:8080/24625
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Arnab Karmakar <ar...@gmail.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
---
M tests/metadata/test_ddl.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Arnab Karmakar: Looks good to me, but someone else must approve
Michael Smith: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/24625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Gerrit-Change-Number: 24625
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-15208: Bump wait time for TestAsyncDDL.test get operation status for async ddl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24625 )
Change subject: IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Gerrit-Change-Number: 24625
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 10:59:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15208: Bump wait time for TestAsyncDDL.test get operation status for async ddl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24625 )
Change subject: IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23359/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Gerrit-Change-Number: 24625
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 03:15:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15208: Bump wait time for TestAsyncDDL.test get operation status for async ddl
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24625 )
Change subject: IMPALA-15208: Bump wait time for TestAsyncDDL.test_get_operation_status_for_async_ddl
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13779/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I547b8c0ccce79ebedb2b9a61e4d09e18b4acbbf8
Gerrit-Change-Number: 24625
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 05:59:16 +0000
Gerrit-HasComments: No