You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/08 07:22:44 UTC
[GitHub] [incubator-dolphinscheduler] clay4444 opened a new pull request
#1771: remove lombok dependency(Last)
clay4444 opened a new pull request #1771: remove lombok dependency(Last)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1771
# What is the purpose of the pull request
this pr is for remove lombok dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1771:
remove lombok dependency(Last)
Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #1771: remove lombok dependency(Last)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1771
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1771: remove lombok dependency(Last)
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1771: remove lombok dependency(Last)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1771#issuecomment-571927265
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1771&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='3.1%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1771&metric=new_coverage&view=list) [3.1% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1771&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10.png' alt='7.7%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1771&metric=new_duplicated_lines_density&view=list) [7.7% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1771&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] clay4444 commented on issue #1771:
remove lombok dependency(Last)
Posted by GitBox <gi...@apache.org>.
clay4444 commented on issue #1771: remove lombok dependency(Last)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1771#issuecomment-571936793
the work of removing lombok dependencies has been completed, but there are still some license files left. I don’t know how to deal with these files, so subsequent work may require you
@dailidong @qiaozhanwei
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1771:
remove lombok dependency(Last)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1771: remove lombok dependency(Last)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1771#issuecomment-571924274
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=h1) Report
> Merging [#1771](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/03ef3943997f43de8c5bc06810bff4e284f6401e?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1771 +/- ##
==========================================
+ Coverage 20.22% 20.32% +0.09%
==========================================
Files 290 290
Lines 14082 14010 -72
Branches 2376 2306 -70
==========================================
- Hits 2848 2847 -1
+ Misses 10908 10843 -65
+ Partials 326 320 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pache/dolphinscheduler/dao/entity/ProjectUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0VXNlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...g/apache/dolphinscheduler/dao/entity/Resource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/dao/entity/UDFUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VREZVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/dao/entity/ResourcesUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZXNVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/dao/entity/ProcessInstance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzSW5zdGFuY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/dao/entity/Session.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9TZXNzaW9uLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...org/apache/dolphinscheduler/dao/entity/Tenant.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9UZW5hbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...pache/dolphinscheduler/dao/entity/AccessToken.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BY2Nlc3NUb2tlbi5qYXZh) | `16.66% <0%> (+11.4%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=footer). Last update [03ef394...9d387ec](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1771: remove lombok dependency(Last)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1771: remove lombok dependency(Last)
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1771#issuecomment-571924274
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=h1) Report
> Merging [#1771](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/03ef3943997f43de8c5bc06810bff4e284f6401e?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1771 +/- ##
==========================================
+ Coverage 20.22% 20.32% +0.09%
==========================================
Files 290 290
Lines 14082 14010 -72
Branches 2376 2306 -70
==========================================
- Hits 2848 2847 -1
+ Misses 10908 10843 -65
+ Partials 326 320 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...pache/dolphinscheduler/dao/entity/ProjectUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0VXNlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...g/apache/dolphinscheduler/dao/entity/Resource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/dao/entity/UDFUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VREZVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/dao/entity/ResourcesUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZXNVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...e/dolphinscheduler/dao/entity/ProcessInstance.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzSW5zdGFuY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/dao/entity/Session.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9TZXNzaW9uLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...org/apache/dolphinscheduler/dao/entity/Tenant.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9UZW5hbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...pache/dolphinscheduler/dao/entity/AccessToken.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BY2Nlc3NUb2tlbi5qYXZh) | `16.66% <0%> (+11.4%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=footer). Last update [03ef394...9d387ec](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1771?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services